Skip to content

Fix FileMaker init to install webviewer addon before local MCP file check#206

Open
eluce2 wants to merge 1 commit intomainfrom
codex/install-addon-before-check
Open

Fix FileMaker init to install webviewer addon before local MCP file check#206
eluce2 wants to merge 1 commit intomainfrom
codex/install-addon-before-check

Conversation

@eluce2
Copy link
Copy Markdown
Collaborator

@eluce2 eluce2 commented Mar 24, 2026

Summary

  • install local ProofKit WebViewer add-on files before checking for an open FileMaker file during CLI init
  • add a dedicated FileMaker service hook for local webviewer add-on install in the live service
  • cover initial prompt and retry flow with tests that assert add-on install attempts
  • add a changeset for @proofkit/cli

Testing

  • pnpm run ci

Summary by CodeRabbit

  • Bug Fixes

    • Improved FileMaker webviewer initialization sequence to ensure local add-on files are installed before checking for open FileMaker files in the local MCP server.
  • Tests

    • Updated test suite to track and verify add-on installation attempts during FileMaker initialization flows.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 24, 2026

🦋 Changeset detected

Latest commit: c79f183

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@proofkit/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
proofkit-docs Ready Ready Preview Mar 24, 2026 3:44pm

Request Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 24, 2026

Open in StackBlitz

@proofkit/better-auth

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/better-auth@206

@proofkit/cli

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/cli@206

create-proofkit

pnpm add https://pkg.pr.new/proofgeist/proofkit/create-proofkit@206

@proofkit/fmdapi

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmdapi@206

@proofkit/fmodata

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/fmodata@206

@proofkit/typegen

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/typegen@206

@proofkit/webviewer

pnpm add https://pkg.pr.new/proofgeist/proofkit/@proofkit/webviewer@206

commit: c79f183

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1fed11d5-6506-4ec9-9b77-ae6d8a11bd5e

📥 Commits

Reviewing files that changed from the base of the PR and between 06173e6 and c79f183.

📒 Files selected for processing (6)
  • .changeset/fifty-lobsters-remain.md
  • packages/cli/src/core/context.ts
  • packages/cli/src/core/resolveInitRequest.ts
  • packages/cli/src/services/live.ts
  • packages/cli/tests/resolve-init.test.ts
  • packages/cli/tests/test-layer.ts

📝 Walkthrough

Walkthrough

This PR introduces a new method to install local webviewer addon files during FileMaker initialization. The method is called during local MCP detection to ensure addon files are installed before checking MCP server health.

Changes

Cohort / File(s) Summary
Release Configuration
.changeset/fifty-lobsters-remain.md
New patch release entry for @proofkit/cli documenting webviewer addon installation sequencing fix.
Service Interface
packages/cli/src/core/context.ts
Added installLocalWebViewerAddon() method signature to FileMakerService interface returning Eff<void, CliError>.
Service Implementation
packages/cli/src/services/live.ts
Implemented installLocalWebViewerAddon() method that invokes installFmAddonExplicitly for the webviewer addon and converts failures to FileMakerSetupError.
Control Flow Integration
packages/cli/src/core/resolveInitRequest.ts
Added call to fileMakerService.installLocalWebViewerAddon() in the webviewer local MCP detection loop, executed immediately after detectLocalFmMcp() attempt.
Test Layer & Tests
packages/cli/tests/test-layer.ts, packages/cli/tests/resolve-init.test.ts
Extended test harness to track addon installation counts via tracker.addonInstalls field and verify installations occur during interactive MCP detection scenarios.

Sequence Diagram

sequenceDiagram
    participant User
    participant InitProcess as Init Process
    participant FMService as FileMaker Service
    participant LocalMCP as Local MCP Server
    
    User->>InitProcess: Start webviewer initialization
    loop Local MCP Detection
        InitProcess->>FMService: detectLocalFmMcp()
        InitProcess->>FMService: installLocalWebViewerAddon()
        FMService->>FMService: Install webviewer addon files
        InitProcess->>LocalMCP: Check MCP health
        alt MCP healthy
            LocalMCP-->>InitProcess: Ready
        else MCP not ready
            InitProcess->>User: Prompt for action (retry/skip)
        end
    end
    InitProcess-->>User: FileMaker file selection or fallback
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the main change: installing the webviewer addon before checking for an open FileMaker file in the init flow.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/install-addon-before-check

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant