Fix FileMaker init to install webviewer addon before local MCP file check#206
Fix FileMaker init to install webviewer addon before local MCP file check#206
Conversation
🦋 Changeset detectedLatest commit: c79f183 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR introduces a new method to install local webviewer addon files during FileMaker initialization. The method is called during local MCP detection to ensure addon files are installed before checking MCP server health. Changes
Sequence DiagramsequenceDiagram
participant User
participant InitProcess as Init Process
participant FMService as FileMaker Service
participant LocalMCP as Local MCP Server
User->>InitProcess: Start webviewer initialization
loop Local MCP Detection
InitProcess->>FMService: detectLocalFmMcp()
InitProcess->>FMService: installLocalWebViewerAddon()
FMService->>FMService: Install webviewer addon files
InitProcess->>LocalMCP: Check MCP health
alt MCP healthy
LocalMCP-->>InitProcess: Ready
else MCP not ready
InitProcess->>User: Prompt for action (retry/skip)
end
end
InitProcess-->>User: FileMaker file selection or fallback
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
@proofkit/cliTesting
pnpm run ciSummary by CodeRabbit
Bug Fixes
Tests