This repository was archived by the owner on May 16, 2025. It is now read-only.
Create function to init sdk #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ristomcgehee
force-pushed
the
init-sdk
branch
from
580014c to
e7d1ad2
Compare
ristomcgehee
force-pushed
the
init-sdk
branch
from
e7d1ad2 to
23f664a
Compare
cherbel
reviewed
Jan 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in allowing custom strategies there are now more ways to misconfigure the SDK, I figured it would be good to create a dedicated function to initialize the SDK. This also improves the code by not having properties that don't get initialized in the constructor.
Setting
"target": "es2017"to support top-level awaits.Since I had issues when I made other PRs non-backwards compatible, I made this change backwards compatible. If you want to see how the code would look when we remove the public constructor, see 84a65e8. When I update
server/to useinit()instead of the constructor, I will also remove the changes in 23f664a.