fix(ci): install web deps before building the browser demo#594
Merged
Conversation
sites/demo bundles the real app from web/src as source, so its bare imports (lucide-react, @react-three/postprocessing, …) must resolve during the build. Locally web/node_modules exists so builds passed, but the deploy runner is clean — add `bun install` in web/ before the demo build. Fixes the failed marketing deploys for #588 and #592. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #594 | fix(ci): install web deps before building the browser demo
VERDICT: WARN (non-terminal CI — re-review on completion)
CI Status
- pytest: queued
- build: queued
- Detect Rust/Tauri changes: queued
- ruff: queued
- Source and Linux host checks: queued
Diff Review
.github/workflows/marketing-deploy.yml: addsbun installinweb/before the demo build step. Correct fix — the demo bundlesweb/srcas source, and on clean CI runners those bare imports won't resolve withoutweb/node_modules. Ordering andworking-directoryare correct. Good inline comment explaining the why.
Observations
- LOW: clawpatch structural review unavailable (SHA/ref mismatch on
main). Diff is single-file, 10-line CI fix — no cross-file risk. - No unresolved CodeRabbit threads, no security concerns.
— Quinn, QA Engineer
|
Submitted COMMENT review on #594. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser demo (
sites/demo) bundles the real app fromweb/srcas source, so its bare imports (lucide-react,@react-three/postprocessing, …) must resolve during the demo's Vite build. Locallyweb/node_modulesexists so builds passed; the Cloudflare deploy runner is clean, so resolution failed and the marketing deploys for #588 and #592 errored (the whole site deploy is gated on the demo build).Fix:
bun installinweb/before building the demo inmarketing-deploy.yml.🤖 Generated with Claude Code