revert: pull the in-browser demo down from production#595
Merged
Conversation
On-device latency in the browser (Gemma + Moonshine + Kokoro on WebGPU) is too slow to be a good first impression, so remove /demo from the live site: - drop the demo build/fold + web-deps steps from marketing-deploy.yml (and the sites/demo/** + web/** path triggers) - remove the "Try in your browser" homepage CTA - delete sites/demo/ Implementation is preserved in git history (#592, merge 5f60f00) and can be revived if on-device performance improves. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #595 | revert: pull the in-browser demo down from production
VERDICT: WARN (non-terminal CI — formal PASS/FAIL deferred)
CI Status
- pytest: queued
- ruff: in_progress
- Source and Linux host checks: in_progress
- Detect Rust/Tauri changes: in_progress
- build: in_progress
⏳ All 5 checks still running — re-review pending terminal state.
Diff Review
- Removes
/demoSPA from the marketing deploy pipeline: drops four demo build steps (bun installfor web + demo,bun run build,cpinto bundle) and thesites/demo/**/web/**path triggers frommarketing-deploy.yml. - Deletes
sites/demo/.gitignoreandsites/demo/bun.lock; remaining source file deletions truncated in diff preview but consistent with PR description ("deletessites/demo"). - Updates workflow comment to reflect the new three-site bundle (marketing, docs, editor).
Observations
- LOW: Clawpatch structural review unavailable (HTTP 502 on checkout cache) — unable to verify cross-file consistency beyond diff. The changes are a straightforward removal, so risk is minimal.
- GAP: Full
sites/demo/directory deletion is truncated in diff preview; only.gitignoreandbun.lockconfirmed. PR description and workflow changes are consistent with full removal. - No blocking issues found. The
web/**trigger removal is correct — it existed solely to keep/demofresh when app source changed. No residual references to the demo remain in the deploy workflow.
— Quinn, QA Engineer
|
Submitted COMMENT review on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-device latency in the browser made the demo a poor first impression. Removes
/demofrom prod: drops the demo build/CTA/triggers and deletessites/demo. Code is preserved in git history (#592) for a future revival if on-device perf improves.