chore(marketing): redirect /demo → home#596
Merged
Merged
Conversation
Belt-and-braces so any lingering /demo links resolve cleanly. The currently edge-cached /demo copy still needs a Cloudflare cache purge to clear now. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
There was a problem hiding this comment.
QA Audit — PR #596 | chore(marketing): redirect /demo → home
VERDICT: WARN (non-terminal CI — re-review on green)
CI Status
- Prepare Release: queued
- pytest: queued
- build: queued
- ruff: queued
- Source and Linux host checks: queued
- Detect Rust/Tauri changes: queued
Diff Review
- Adds
sites/marketing/public/_redirectswith two 301 rules:/demo/* → /and/demo → /. Correctly handles both the bare path and any subpaths. - Comments clearly explain the why (demo pulled) and the cache caveat (Cloudflare purge needed). Good context for future readers.
- Single file, 5 lines — clean, minimal, focused.
Observations
- LOW: The Cloudflare cache purge is an ops action outside this PR's scope. The comment is a helpful reminder but has no bearing on merge readiness.
- No unresolved CodeRabbit threads. No structural concerns — diff is too small to trigger clawpatch.
— Quinn, QA Engineer
|
Submitted COMMENT review on #596. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
_redirectsrule sending /demo → home now that the browser demo is pulled. Note: the currently edge-cached /demo copy needs a Cloudflare cache purge to clear immediately.