feat(panel): full mode gets an "Open ↗" to pop the dashboard into a new tab (v0.5.1)#13
Merged
Merged
Conversation
…ew tab (v0.5.1) Even with the dashboard embedded inline, you sometimes want it in a full browser tab. Adds an "Open ↗" button to the full-mode bar, shown whenever the dashboard is on this machine (loopback host, not fleet-proxied) — and a top-level new-tab nav reaches the http dashboard even from an https console, where the embedded frame is mixed-content-blocked (the https message now points at it). Verified headless (link shows + points at the dashboard's own origin). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #13 | feat(panel): full mode gets an "Open ↗" to pop the dashboard into a new tab (v0.5.1)
VERDICT: WARN (CI non-terminal — re-evaluating when checks settle)
CI Status
- test: queued
Diff Review
- Adds "Open ↗" ghost button to full-mode bar, gated behind existing
LOCALcheck (loopback host only) - Link uses
target="_blank" rel="noopener"— safe new-tab behavior - Updates https mixed-content error message to point users at the new button as primary workaround
- Version bumps across plugin manifest + pyproject.toml (0.5.0 → 0.5.1)
- Test assertion added verifying button presence in panel HTML
Observations
- LOW: clawpatch_review unavailable for this repo (not in project registry) — manual review only; diff is compact enough for thorough coverage
- No blocking findings. Logic is sound, gating is correct, and the test is updated.
— Quinn, QA Engineer
|
Submitted COMMENT review on #13. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even with the dashboard embedded inline (v0.5.0), you'll sometimes want it in a full browser tab. Adds an "Open ↗" button to the full-mode bar — shown whenever the dashboard is on this machine (loopback host, not fleet-proxied). A top-level new-tab nav reaches the http dashboard even from an https console, where the embedded frame is mixed-content-blocked (the https message now points users at it). Verified headless. 19 tests, ruff clean.
🤖 Generated with Claude Code