feat(panel): responsive full-stretch viewport, live nav, fidelity + anti-detection (v0.6.1)#15
Merged
Merged
Conversation
… anti-detection (v0.6.1) Four fixes for using the interactive panel in a real dock: - Full-stretch, responsive viewport. A debounced ResizeObserver reports the dock's size; the server resizes Chrome's layout viewport to match (× DPR up to 2) via Emulation.setDeviceMetricsOverride and re-arms the screencast at that size — the page reflows to fill instead of a fixed landscape box in dead space. Canvas fills the stage. Validated live: dock 900x1200 → frames at 900x1200. - The agent's navigation is now visible. A cross-process nav tears down Chrome's screencast, so you saw the first page but nothing as the agent moved around. Re-arm on every nav-complete signal (loadEventFired / frameStoppedLoading / frameNavigated / navigatedWithinDocument, debounced). Root-caused via CDP event trace: data:/SPA navs emit frameStoppedLoading, NOT loadEventFired. Validated: every page paints. - Higher fidelity. JPEG quality 60 → 80 (configurable via stream_quality) + hi-dpi rendering. - Anti-detection (stealth). New stealth / user_agent / browser_args config to help past bot walls (Google, Reddit, Cloudflare): stealth drops navigator.webdriver and, headless, swaps the HeadlessChrome UA for a real one. Launch flags (headed / profile / stealth / …) moved to a shared runtime.launch_flags and now also apply when a session is started from the panel, not just the agent's browser_open. One shared write-lock on the CDP socket (reader acks/re-arm + request input/resize). 45 host-free tests pass; ruff clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #15 | feat(panel): responsive full-stretch viewport, live nav, fidelity + anti-detection (v0.6.1)
VERDICT: WARN
CI Status
- test: success ✅
Diff Review
browser_panel.py: clean —launch_flagswired into panel/nav,stream_qualitypassthrough, CSS full-stretch +overflow:hidden,ResizeObserver(180ms debounce) →sendResize()on connect and resize. All good patterns.browser_stream.py(visible):viewport_metrics()clamps defensively (CSS ≤2048, scale ∈[1,2], frame ≤2560)._NAV_DONEfrozenset covers all four CDP nav-complete signals.CDPStream.__init__gains quality/lock/last_arm fields. Docstring is thorough.
Observations
- GAP: 340 of 560 diff lines truncated — the lock serialization, nav re-arm logic, resize CDP command (
Emulation.setDeviceMetricsOverride), anddispatch()changes are not visible. These are the core of the PR's claims. - GAP:
runtime.pyis a new module not visible in the truncated diff —launch_flags()is imported by bothbrowser_panel.pyand presumablytools.py. Cannot review stealth/UA/flag logic. - GAP: clawpatch structural review unavailable (HTTP 502 — checkout cache error). No cross-file analysis performed.
- LOW:
viewport_metricsfloors scale at 1.0 (max(1.0, …)) — sub-1-DPR displays get upscaled. Intentional, minor bandwidth trade-off. - LOW:
sendResize()guards>10px— panel collapse yields no resize, screencast keeps running at last size. Acceptable. - LOW:
_NAV_DONEdocstring mentions onlyframeNavigated/loadEventFired, but the frozenset also includesframeStoppedLoading/navigatedWithinDocument. Code is correct; docstring is slightly incomplete.
— Quinn, QA Engineer
|
Submitted COMMENT review on #15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four fixes for actually using the interactive panel in a docked/resized console.
1. Full-stretch, responsive viewport
The canvas painted frames at Chrome's fixed viewport (1280×577 landscape) and CSS only shrank-to-fit — so a tall/wide dock showed a small landscape box in dead space. Now a debounced
ResizeObserverreports the dock size and the server resizes Chrome's layout viewport to match (× device-pixel-ratio, ≤2) viaEmulation.setDeviceMetricsOverride, re-arming the screencast at the new size. The page reflows to fill; the canvas fills the stage. Validated live: dock 900×1200 → frames arrive at 900×1200.2. The agent's navigation is now visible (the big one)
A cross-process navigation swaps Chrome's render widget and silently kills the screencast — so you saw the first page load but nothing as the agent moved around or into sub-pages. Root-caused with a CDP event trace:
data:/SPA navigations emitframeStoppedLoading/navigatedWithinDocument, notloadEventFired. The stream now re-arms on the full set of nav-complete signals (debounced). Validated: 4 sequential navigations each paint a fresh frame (was: only the first).3. Higher fidelity
JPEG quality 60 → 80 (configurable via
stream_quality) plus hi-dpi rendering (deviceScaleFactor up to 2×).4. Anti-detection (
stealth)New knobs to help past bot walls (Google, Reddit, Cloudflare):
stealthdrops thenavigator.webdriverautomation flag and, when headless, swaps the "HeadlessChrome" UA for a real desktop one; plususer_agent/browser_argsoverrides. Most reliable paired withheaded: true+ a logged-inprofile. No setting defeats detection entirely — documented as such. Launch flags moved to a sharedruntime.launch_flagsand now also apply when a session is started from the panel (Start button / URL bar), not just the agent'sbrowser_open.Notes
stream_quality,stealth,user_agent,browser_args(all in Settings ▸ Plugins).viewport_metricsclamping,launch_flags/stealth, resize + nav wiring in the page,/navapplies launch flags.🤖 Generated with Claude Code