feat(read-tools): github_pr_diff — a PR's full unified diff (v0.1.3)

[mabry1985]

F1.1 of the codified-delivery-loop plan (protoAgent docs/plans/codified-delivery-loop.md, M1): the adversarial review workflow's finder subagents need to read the change itself, not just the metadata github_get_pr returns.

• github_pr_diff(number, repo?, max_chars=12000) — gh pr diff via run_gh
• Same contract as the sibling read tools: default-repo fallback (resolve_repo), bad_repo validation before any gh call, check_gh_error degradation to a readable Error: string, truncation note at max_chars
• 5 tests over the mocked run_gh (happy path + args, truncation, empty diff, bad repo short-circuit, gh error)

92 passed. Version 0.1.3 lockstep (manifest + pyproject).

Consumed next by protoAgent's code-review workflow recipe (review-finder allowlist) and later the board's blocking review gate (M5).

🤖 Generated with Claude Code

[protoquinn]

👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow.

[protoquinn]

QA Audit — PR #20 | feat(read-tools): github_pr_diff — a PR's full unified diff (v0.1.3)

VERDICT: PASS (with observations)

---

CI Status

• No CI checks found for this PR — unverified. Treated as a Gap, not a blocker.

Diff Review

• Adds github_pr_diff(number, repo?, max_chars=12000) to read_tools.py — wraps gh pr diff with the identical contract pattern as github_get_commit_diff (resolve_repo → bad_repo → run_gh → check_gh_error → strip → truncate).
• 5 tests in tests/test_read_tools.py: happy path + arg shape, truncation, empty diff, bad-repo short-circuit (asserts run_gh not called), gh error surfacing.
• Version bumped 0.1.2 → 0.1.3 lockstep in protoagent.plugin.yaml + pyproject.toml.

Observations

• LOW: clawpatch_review timed out — structural review skipped. Diff-based review found no issues; the tool is a narrow, well-factored addition following an established pattern.
• GAP: CI not accessible — no checks visible for this PR. Not a code defect.

— Quinn, QA Engineer

[protoquinn]

Submitted COMMENT review on #20.

[protoquinn]

✅ CI went terminal-green with no blockers on the prior review — promoting it to APPROVED per the approve-on-green policy (#748).

[protoquinn]

CI terminal-green, no blockers on prior review — auto-approving on green (#748).

[protoquinn]

QA Audit — PR #20 | feat(read-tools): github_pr_diff — a PR's full unified diff (v0.1.3)

VERDICT: PASS (pending CI; auto-promotes on terminal-green)

---

CI Status

• test: in_progress

Once test completes terminal-green, the approve-on-green policy automatically promotes this review to APPROVED and the PR merges. No further review needed.

Incremental Diff (8e383c1 → 75f3192)

• Version bump 0.1.5 → 0.1.6 in protoagent.plugin.yaml + pyproject.toml — the only change since prior review. The github_pr_diff tool and 5 tests are unchanged from what was PASSed at 8e383c1.
• Clawpatch structural review: no findings in diff-touched feature slices.

Observations

• LOW: clawpatch report had 2 high-level notes but no structured findings surfaced — diff-based review remains clean.
• GAP: CI still running (test: in_progress) — approve-on-green handles promotion.

— Quinn, QA Engineer

[protoquinn]

Submitted COMMENT review on protoLabsAI/github-plugin#20.