chore: bring repo to plugin standard — CI, pyproject, host-free suite, stdlib-shadow fix#1
Merged
Merged
Conversation
…, stdlib-shadow fix - pyproject.toml (ruff + pytest config) + requirements-dev.txt + host-free CI on the Namespace runner - rename calendar.py -> gcal.py: a root-level calendar.py shadows stdlib calendar (which stdlib email imports), breaking any Python started from this directory - __init__.py: no top-level relative imports — pytest imports a repo-root __init__.py as a nameless top-level module during package setup; service imports now live inside functions (both invariants pinned by tests) - tests: synthetic-package conftest bootstrap (google_plugin), drop the flat-import dual-path hack + tests/pytest.ini rootdir dodge; add manifest-coherence, register()-wiring, tool-wrapper and four-rules view tests (8 -> 18 tests) - manifest: min_protoagent_version 0.71.0 (public_paths, #1345) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
There was a problem hiding this comment.
QA Audit — PR #1 | chore: bring repo to plugin standard — CI, pyproject, host-free suite, stdlib-shadow fix
VERDICT: WARN (non-blocking — CI still queued, re-review on terminal)
CI Status
- test: queued
Diff Review
calendar.py→gcal.py: fixes real stdlib-shadow bug (import calendarwould resolve to this module, breakingemailand anything else). Pinned bytest_no_stdlib_shadowing_module_names. Correct.__init__.pylazy imports: allfrom . import xmoved inside functions — correct pattern for pytest 8+ (repo-root__init__.pyloaded as nameless top-level module). Consistent across all tool functions andregister().- Lazy
_CREDSinit: module-levelNone, populated by_creds()(empty-credentials fallback) or overwritten byregister().register()writes the global directly, so the cache-before-register path resolves correctly. - CI workflow (
.github/workflows/ci.yml): clean, host-free, Namespace runner with fallback.
Observations
- GAP: Diff truncated at 200/674 lines — ~474 lines (tests, pyproject.toml, requirements-dev.txt, manifest, remaining
__init__.py) not directly reviewed. - GAP: Clawpatch structural review unavailable (502 — repo not in checkout cache). Cross-file analysis (e.g.
view.py↔gcal.pyinterface after rename, test coverage ofregister()wiring) not verified. - GAP:
path_existsnot available on this pr_inspector — could not verifyrequirements-dev.txt,gcal.py, orview.pyexist on the PR head. - LOW: CI non-terminal —
teststill queued. PR description reports 18/18 pass locally with ruff clean; formal PASS/FAIL deferred to CI-completion re-review.
— Quinn, QA Engineer
|
Submitted COMMENT review on #1. |
This was referenced Jul 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings google-plugin up to the standalone-plugin operational standard (projectBoard/artifact shape).
What
.github/workflows/ci.yml): ruff check + format-check (tests/) + pytest on the Namespace runner, host-free viarequirements-dev.txt.calendar.py→gcal.py: a root-levelcalendar.pyshadows the stdlibcalendarmodule — stdlibemailimports it, so any Python started from this directory exploded with a bizarre circular-import error. Pinned bytest_no_stdlib_shadowing_module_names.__init__.py: relative imports moved inside functions. pytest (8+) makes the repo root aPackagenode and imports its__init__.pyas a nameless top-level module at setup — any top-levelfrom . import xbreaks the whole suite. This is the shape projectBoard-plugin already uses. Pinned bytest_init_has_no_top_level_relative_imports.tests/pytest.inirootdir dodge are gone); new manifest-coherence,register()-wiring, tool-wrapper, and four-rules view tests (view path asserted against what the router actually serves).min_protoagent_version: 0.71.0(first release withpublic_paths, #1345).Test
pip install -r requirements-dev.txt && pytest -qfrom the repo root — 18 passed, ruff clean, verified in a clean py3.12 venv with no protoAgent host importable.🤖 Generated with Claude Code