feat(gmail): gmail_mark_read — clear UNREAD by message ids or whole thread (v0.3.0)#6
Merged
Conversation
…hread (v0.3.0)
The one mailbox mutation beyond drafts: batchModify removes the UNREAD label from
up to 1000 message ids, or threads/{id}/modify clears a whole thread. Never
archives, deletes, or sends — posture docs updated to say exactly that. Uses the
gmail.modify scope the default connect flow already requests.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #6 | feat(gmail): gmail_mark_read — clear UNREAD by message ids or whole thread (v0.3.0)
VERDICT: WARN (CI queued — re-review on terminal)
CI Status
- test: queued
Diff Review
gmail.mark_read()ingmail.py: two clean paths —threads/{id}/modifywithremoveLabelIds: [UNREAD]for whole-thread,messages/batchModifyfor up to 1000 ids. Blank-id filter and cap are correct. Defensiveor 1fallback on thread path is reasonable.- Tool wrapper in
__init__.pyvalidates at least one target, delegates consistently with existing_runpattern, and formats output appropriately. - 3 new tests cover batch body + blank-id filtering, thread modify path, and tool validation/count reporting — all follow the existing mock-transport style.
- Documentation updated across README, module docstring, plugin manifest, and
pyproject.toml— posture is explicit and consistent: "never archives, deletes, or sends."
Observations
- LOW: clawpatch structural review unavailable (502 — repo not in checkout cache). Diff-only review is sufficient for this scope; no cross-file risk detected manually.
- No unresolved CodeRabbit threads. No blocking findings.
— Quinn, QA Engineer
|
Submitted COMMENT review on #6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability the agent was missing: mark mail as read for inbox triage.
What
gmail.mark_read():messages/batchModifywithremoveLabelIds: [UNREAD]for up to 1000 ids (blank ids dropped), orthreads/{id}/modifyfor a whole thread.gmail_mark_read(message_ids | thread_id)— validates a target is given, reports the count marked.gmail.modify, which the existing refresh token and the default connect scopes already carry — works with no re-consent.Test
46 passed (3 new: batch body + blank-id filtering, thread modify, tool wrapper validation/count), ruff clean, host-free.
🤖 Generated with Claude Code