chore: board → v0.31.0; review gate ON by default for spawned teams#6
Merged
Conversation
v0.30.0 = the blocking review gate (plan M5): the loop runs the host's adversarial code-review workflow (protoAgent ADR 0077) on every opened PR and bounces blocking findings back to the coder, bounded by review_fix_max, exhaustion → Blocked (never a silent merge). v0.31.0 = the DESIGN gate (plan M6): large/architectural features need a design citing an ADR before mark_ready. review_gate: true is safe ahead of the next core release — on a host whose core predates graph.review.findings the gate goes loudly inert rather than silently passing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #6 | chore: board → v0.31.0; review gate ON by default for spawned teams
VERDICT: WARN (pending CI — approve-on-green policy promotes to APPROVED once every check is terminal-green)
CI Status
- 7 checks in progress (Verify workspace config, Python tests, A2A live smoke, Web E2E smoke, Lint, Fleet integration, gitleaks) — all non-terminal.
Diff Review
- Single-file change to
protoagent.bundle.yaml: bumpsproject_boardplugin from v0.29.3 → v0.31.0 and addsreview_gate: true+review_fix_max: 2underconfig.project_board. The bump skips v0.30.0 but that's intentional — v0.31.0 subsumes both the M5 (blocking review gate) and M6 (DESIGN gate) plans. - The inline comment block clearly documents the adversarial-review behavior and the inert-on-old-core safety property. Verified that
verified_againstremains unchanged at 0.93.1, consistent with the assertion that the gate degrades loudly on cores lacking the findings convention.
Observations
- No unresolved CodeRabbit threads.
- No defects, no blocking issues, no security concerns. The change is purely a config version bump + enablement toggle.
- All findings are gated on CI completing green; the approve-on-green policy will promote this review to APPROVED automatically once every check passes.
— Quinn, QA Engineer
|
Submitted COMMENT review on #6. |
There was a problem hiding this comment.
CI terminal-green, no blockers on prior review — auto-approving on green (protoLabsAI#748).
|
✅ CI went terminal-green with no blockers on the prior review — promoting it to APPROVED per the approve-on-green policy (#748). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest of the delivery-loop plan's M7 for this bundle:
project_boardpin → v0.31.0 (v0.30.0 = blocking review gate, plan M5; v0.31.0 = DESIGN gate, plan M6)config.project_board.review_gate: true— a freshly spawned Lead Engineer team ships with the adversarial review gate ON. Blocking findings (blocker/major surviving the verify pass) bounce to the coder with the findings in the retry prompt, bounded byreview_fix_max: 2; exhaustion → Blocked, never a silent merge.difficulty ∈ {large, architectural}at the store level.verified_againststays 0.93.1: on that core the review gate goes loudly inert (nograph.review.findings→ logged, review-pending retried, never a silent pass), so the default is safe to ship ahead of the core release that carries ADR 0077.🤖 Generated with Claude Code