chore: verified_against → 0.94.0 (activates the review gate)#7
Conversation
…e sdk plugin-tools fix) 0.94.0 ships graph.review.findings (the convention the board's review_gate parses — the gate goes from loudly-inert to ACTIVE on this core) and the sdk.run_subagent plugin-tools fix (protoLabsAI#1857) the code-review workflow's finders need. Re-verify against it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #7 | chore: verified_against → 0.94.0 (activates the review gate)
VERDICT: PASS
CI Status
- All 7 checks still running (Web E2E smoke, Lint, Python tests, Fleet integration, Verify workspace config, A2A live smoke, gitleaks) — non-terminal
Diff Review
- Single-line version bump in
protoagent.bundle.yaml:verified_againstfrom0.93.1→0.94.0 - Correct per ADR 0049: the verify-bundle smoke will now check out protoAgent 0.94.0, which ships the active review gate (ADR 0077) and the
sdk.run_subagentfix (protoLabsAI#1857) - No code changes, no logic risk, no dependency changes
Observations
- No findings — trivial, well-scoped chore bump
— Quinn, QA Engineer
⏳ CI is still settling. Under the approve-on-green policy, this review will be promoted to a formal APPROVE automatically once every check reaches terminal-green. No further action needed from Quinn on this pass.
|
Submitted COMMENT review on #7. |
There was a problem hiding this comment.
QA Audit — PR #7 | chore: verified_against → 0.94.0 (activates the review gate)
VERDICT: WARN
CI Status
- Python tests: failure (unrelated to this change — see below)
- Web E2E smoke: success
- Lint (ruff + import contracts): success
- Fleet integration (multi-instance): success
- Verify workspace config: success
- A2A live smoke (lean tier): success
- gitleaks (tree): success
Diff Review
- Single-line version bump in
protoagent.bundle.yaml:verified_againstfrom0.93.1→0.94.0 - Correct per ADR 0049: the verify-bundle smoke will now check out protoAgent 0.94.0, which ships the active review gate (ADR 0077) and the
sdk.run_subagentfix (protoLabsAI#1857) - No code changes, no logic risk, no dependency changes
Observations
- MEDIUM: Python tests failed in CI, but this is a single-line YAML version bump — the failure cannot be caused by this PR and is likely pre-existing or transient. Recommend re-running the Python test suite or confirming the flake is tracked separately before merging.
— Quinn, QA Engineer
|
Submitted COMMENTED review on |
There was a problem hiding this comment.
CI terminal-green, no blockers on prior review — auto-approving on green (protoLabsAI#748).
|
✅ CI went terminal-green with no blockers on the prior review — promoting it to APPROVED per the approve-on-green policy (#748). |
There was a problem hiding this comment.
QA Audit — PR #7 | chore: verified_against → 0.94.0 (activates the review gate)
VERDICT: PASS
CI Status
- Web E2E smoke: ✅
- Verify workspace config: ✅
- Fleet integration (multi-instance): ✅
- A2A live smoke (lean tier): ✅
- Lint (ruff + import contracts): ✅
- Python tests: ✅
- gitleaks (tree): ✅
Diff Review
- Single-line version bump:
verified_against: 0.93.1→0.94.0inprotoagent.bundle.yaml - Activates the review-gate feature that was loudly-inert on 0.93.1
Observations
- No findings. Clean version pin bump, CI terminal-green.
— Quinn, QA Engineer
|
Submitted APPROVED review on #7. |
1 participant
protoAgent v0.94.0 ships
graph.review.findings(ADR 0077) and thesdk.run_subagentplugin-tools fix (protoLabsAI#1857). On 0.93.1 the bundle'sreview_gate: truedefault runs loudly-inert; on 0.94.0 it's fully active. verify-bundle re-runs the smoke against the new core ref.🤖 Generated with Claude Code