feat: portfolio_cancel_feature — PM-side task cancel on a team board (v0.14.7)#31
Merged
Conversation
…eam board (v0.14.7)
Roxy's task_close failed with 'unknown issue' because the PM had no write path
to a team's board — she could dispatch but never cancel or recover a stuck/
duplicate task. portfolio_cancel_feature(board, feature_id, reason='') POSTs to
the team's project_board /features/{id}/cancel over the SAME bearer the reads
use (the write twin of _fetch_board_features), moving the feature to the
terminal 'cancelled' lane so the team stops working it. The managed repo + any
PR already opened are untouched. Pairs with the dispatch dedup (#25) to give
the PM real supervisory control over a team's queue.
Closes #27.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #31 | feat: portfolio_cancel_feature — PM-side task cancel on a team board (v0.14.7)
VERDICT: WARN (pending CI — test is queued)
CI Status
- test: queued ⏳
Diff Review
- Clean addition:
_cancel_board_featuremirrors_fetch_board_featuresin structure — same bearer, security policy check, httpx timeout, error-handling pattern portfolio_cancel_featuretool follows existing conventions: board lookup via_remote_by_name,_BoardUnavailablecaught and formatted as error string, happy path returnsjson.dumps- Version bump 0.14.6 → 0.14.7 consistent across
__init__.py,pyproject.toml,protoagent.plugin.yaml - Tool registration includes
portfolio_cancel_featurein the return list and the test assertions
Observations
- LOW: clawpatch structural review unavailable for this repo (not in project registry) — diff reviewed manually; no issues found
- GAP: CI still queued — formal PASS/FAIL deferred until checks complete. No blocking findings in the diff itself.
— Quinn, QA Engineer
|
Submitted COMMENT review on #31 — pending CI. The diff is clean; the formal PASS will land once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27. The sharpest gap from Roxy's operational experience: she could
portfolio_dispatchbut never un-dispatch — hertask_closefailed with 'unknown issue' because the PM has no write path to a team's board.Behavior
portfolio_cancel_feature(board, feature_id, reason='')POSTs to the team'sproject_board/features/{id}/cancelover the same bearer the reads already use (the write twin of_fetch_board_features), moving the feature to the terminalcancelledlane so the team stops working it and it clears from the active view. The managed repo + any PR already opened are untouched; the optionalreasonis recorded in the board's audit.Direct project_board API (not an A2A instruction to the lead) because canceling is a mechanical board write, and the PM already talks to the team's project_board API for reads — consistent and deterministic.
Pairs with the dispatch dedup (#25): together they give the PM real supervisory control over a team's queue — don't stack duplicates, and cancel what's stuck.
Tests
Posts to the right
/features/{id}/cancelURL with the bearer + reason; unknown board; a 404/HTTP error surfaces cleanly. 119 tests pass; ruff clean. v0.14.6 → v0.14.7.🤖 Generated with Claude Code