feat: declare the fusion delegate + gap-fill its gateway (ADR 0064 P3)#36
Merged
Merged
Conversation
…, v0.16.0) Companion to projectBoard-plugin's fusion-rung wiring: the shipped team template now declares a real fusion delegate (openai-type, protolabs/fusion) and wires it into project_board.coder_solve_fusion_delegate, so a team spun up from this template can actually reach rung 4 on the hardest features -- not just have the board-seam machinery support it in principle. url/api_key ship blank on the fusion delegate, same as the team's own model block -- so _inherit_host_gateway needed extending: it now ALSO gap-fills any delegates: entry of type openai with a blank url from the same host gateway the model block inherits (a per-delegate url is left alone, same discipline). No per-team creds prep needed for fusion any more than for the team's brain. README's coder-ladder section gets a new "fusion" subsection documenting the config and the can't-tool-call design constraint. Shipped-template content contract extended (fusion delegate present + wired); new _inherit_host_gateway tests for the delegate gap-fill (fills blank, respects a per-delegate url, leaves non-openai delegates alone). 144 passed (was 127; +17 new/updated across the shipped-template contract and gateway-inherit coverage). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
There was a problem hiding this comment.
QA Audit — PR #36 | feat: declare the fusion delegate + gap-fill its gateway (ADR 0064 P3)
VERDICT: WARN (CI still queued — non-terminal; re-review for PASS/FAIL once checks settle)
CI Status
- test: queued ⏳
Diff Review
- 5 files, ~255 lines: shipped template declares
fusiondelegate (openaitype, blankurl/api_key), wires it intoproject_board.coder_solve_fusion_delegate, extends_inherit_host_gatewayto gap-fill blank-URLopenaidelegates from the host gateway, updates README, bumps version 0.15.1→0.16.0. __init__.py:_inherit_host_gatewayrefactored from early-return tochanged-flag pattern — the delegates loop is gated ontype: openai+ blankurl, correctly respecting per-delegate gateways and leaving non-openai delegates untouched.- Template YAML (
langgraph-config.yaml) correctly declaresfusiondelegate and wirescoder_solve_fusion_delegate: fusion+coder_solve_fusion_k: 2.
Observations
- LOW: Clawpatch structural review unavailable for this repo (not in project registry) — manual diff review only.
- LOW: CI
testcheck still queued at review time; no terminal pass/fail signal yet. Submit PASS/FAIL on re-review once terminal. - The
_inherit_host_gatewayearly-return →changed-flag refactor is behavior-preserving for the model block and correctly additive for delegates. The_host_gateway()call moves outside the guard but is side-effect-free (env/config reads only).
— Quinn, QA Engineer
|
Submitted COMMENT review on #36. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Companion to projectBoard-plugin#64 (the board-seam fusion-rung wiring). The shipped team template now declares a real
fusiondelegate and wires it intoproject_board.coder_solve_fusion_delegate, so a team spun up from this template can actually reach rung 4 on the hardest features — not just have the board-seam machinery support it in principle.Gateway inheritance, extended
url/api_keyship blank onfusion, same as the team's ownmodel:block — so_inherit_host_gatewayneeded extending: it now also gap-fills anydelegates:entry oftype: openaiwith a blankurlfrom the same host gateway the model block inherits (a per-delegateurlis left alone, same discipline as a per-team model gateway). No per-team creds prep needed for fusion any more than for the team's own brain.Docs
README's coder-ladder section gets a new "fusion" subsection: the config, and the load-bearing design constraint — fusion can't tool-call (a plain completion, not an ACP session), so the board seam hands it current file content and writes its reply's files into a fresh worktree itself.
Tests
test_shipped_template_declares_the_fusion_delegate_gateway_blank,test_shipped_template_wires_fusion_into_the_coder_solve_ladder._inherit_host_gatewaycoverage: fills a blankopenai-delegateurl, respects a delegate's ownurl, leaves non-openaidelegates untouched.144 passed (was 127; +17 new/updated).
Version bumped 0.15.1 → 0.16.0 (new capability).
🤖 Generated with Claude Code