feat: fix: dashboard team card shows "ephemeral" label even when auto_dispose is false (#26)#38
Merged
Conversation
…_dispose is false (#26)
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
There was a problem hiding this comment.
QA Audit — PR #38 | feat: fix: dashboard team card shows "ephemeral" label even when auto_dispose is false (#26)
VERDICT: WARN ⏳ (CI pending — re-review once test completes)
CI Status
- test: queued
Diff Review
view.py:144— one-line fix: badge condition changed fromb.spawnedtob.auto_dispose. Correct —spawnedreflects runtime origin,auto_disposeis the config flag the badge should gate on.tests/test_view.py— three well-scoped regression tests added:- Template string check confirms
b.auto_disposeis referenced. - Overview API test verifies
auto_disposeis exposed per-board (alpha→True,ext→False). - Monkeypatch integration test proves a board with
auto_dispose=Falsegets no ephemeral badge.
- Template string check confirms
Observations
- No unresolved CodeRabbit threads.
- No HIGH or CRITICAL findings. Fix is targeted, tests cover the regression.
— Quinn, QA Engineer
|
Submitted COMMENT review on #38. |
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[coder.solve rung=greedy gens=1] solved 1-shot