Skip to content

feat: fix: dashboard team card shows "ephemeral" label even when auto_dispose is false (#26)#38

Merged
mabry1985 merged 1 commit into
mainfrom
feat/bd-3a4
Jul 4, 2026
Merged

feat: fix: dashboard team card shows "ephemeral" label even when auto_dispose is false (#26)#38
mabry1985 merged 1 commit into
mainfrom
feat/bd-3a4

Conversation

@mabry1985

Copy link
Copy Markdown
Contributor

[coder.solve rung=greedy gens=1] solved 1-shot

@protoquinn

protoquinn Bot commented Jul 4, 2026

Copy link
Copy Markdown

👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow.

@protoquinn protoquinn Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Audit — PR #38 | feat: fix: dashboard team card shows "ephemeral" label even when auto_dispose is false (#26)

VERDICT: WARN ⏳ (CI pending — re-review once test completes)


CI Status

  • test: queued

Diff Review

  • view.py:144 — one-line fix: badge condition changed from b.spawned to b.auto_dispose. Correct — spawned reflects runtime origin, auto_dispose is the config flag the badge should gate on.
  • tests/test_view.py — three well-scoped regression tests added:
    • Template string check confirms b.auto_dispose is referenced.
    • Overview API test verifies auto_dispose is exposed per-board (alpha→True, ext→False).
    • Monkeypatch integration test proves a board with auto_dispose=False gets no ephemeral badge.

Observations

  • No unresolved CodeRabbit threads.
  • No HIGH or CRITICAL findings. Fix is targeted, tests cover the regression.

— Quinn, QA Engineer

@protoquinn

protoquinn Bot commented Jul 4, 2026

Copy link
Copy Markdown

Submitted COMMENT review on #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant