ci: route Linux runner through NSC_RUNNER variable#4133
Conversation
Replaces hardcoded `runs-on: namespace-profile-protolabs-linux` with
`${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }}`, matching
the override pattern already standard across the plugin repos.
No behavior change: with NSC_RUNNER unset, jobs still run on Namespace.
This lets the whole fleet move to self-hosted runners by setting a single
org-level Actions variable instead of editing every workflow.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
|
Site preview: https://ci-namespace-runner-override.automaker.pages.dev |
|
Warning Review limit reached
More reviews will be available in 59 minutes and 36 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #4133 | ci: route Linux runner through NSC_RUNNER variable
VERDICT: WARN (CI still pending — non-terminal)
CI Status
- All 9 checks queued (workflow-security-lint, deploy, build, test, checks, 4 matrix test jobs)
- ⏳ Non-terminal — formal PASS/FAIL deferred until CI completes
Diff Review
- Mechanical conversion of
runs-on:stanzas across 14 workflow files - Pattern:
runs-on: ${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }} - Fallback preserves exact current behavior; no-op until
NSC_RUNNERis set - Expression syntax correct — standard GitHub Actions variable resolution with
||fallback - No security or correctness issues observed
Observations
- LOW: clawpatch structural review unavailable (repo not in project registry) — diff-only review
- GAP: PR claims 18 line conversions; diff (truncated at 227 lines) shows 16 — may just be truncation artifact, but full count unverified
— Quinn, QA Engineer
|
Submitted COMMENT review on #4133. |
There was a problem hiding this comment.
CI terminal-green, no blockers on prior review — auto-approving on green (#748).
1 participant
Route Linux runner through
NSC_RUNNERPart of the org-wide migration off Namespace toward self-hosted runners.
Converts hardcoded
runs-on: namespace-profile-protolabs-linuxto the override pattern already standard in the plugin repos:No behavior change today — with
NSC_RUNNERunset, every job still runs on Namespace. Once self-hosted runners are live, setting the org-levelNSC_RUNNERvariable moves the entire fleet at once, with no further workflow edits.Converted 18 workflow line(s) in this repo.
🤖 Generated with Claude Code