fix(release): 0.6.1 — re-format provider + workflow files for oxfmt#5
Merged
Merged
Conversation
The 0.6.0 tag-push fired publish.yml's quality gate which caught
oxfmt issues in the files I added for the proto provider (provider.ts,
provider.test.ts, docs/providers.md, CHANGELOG.md, package.json, and
the new publish.yml itself). Auto-formatted via `pnpm format`,
which the format gate now accepts.
Bumped to 0.6.1 instead of re-using the v0.6.0 tag because:
1. Tag immutability is the rule we want — never re-publish the
same version even when an earlier attempt didn't reach npm.
2. The v0.6.0 git tag stays in place as the historical "this attempt
failed" marker; v0.6.1 will be the first version actually on npm.
After merge: tag v0.6.1 → publish workflow → @protolabsai/protopatch@0.6.1
on npm. Then workstacean Dockerfile swaps from `github:` to
`@protolabsai/protopatch@^0.6.1`.
mabry1985
commented
May 25, 2026
mabry1985
left a comment
mabry1985
left a comment
Author
There was a problem hiding this comment.
QA Audit — PR #5 | fix(release): 0.6.1 — re-format provider + workflow files for oxfmt
VERDICT: WARN
CI Status
- Analyze (typescript): queued
- test: queued
- Review dependency changes: queued
Diff Review
package.json: version bump 0.6.0 → 0.6.1; field reorder (publishConfig moved below type, repository below license) — all cosmeticCHANGELOG.md+docs/providers.md:oxfmttable reformatting (pipe-alignment normalization); markdown bullet indent fix (+→-) in providers.md line 407.github/workflows/publish.yml: quote style ('v*.*.*'→"v*.*.*") and spacing normalization per oxfmtsrc/provider.test.ts: multi-line argument formatting only — no behavioral change
All changes are pnpm format-driven cosmetic reformatting or a straightforward version bump. The PR author confirms 731 tests pass (1 pre-existing skip) and format:check is clean.
Observations
- LOW: CI still queued at time of review — APPROVED contingent on all checks passing
- LOW:
package.jsonfield reorder is cosmetic but worth notingrepositorynow comes afterlicenserather than adjacent topublishConfig; no functional impact - INFO: Tag immutability rationale (never re-tag 0.6.0, bump to 0.6.1) is sound release hygiene
- INFO: No unresolved CodeRabbit threads
— Quinn, QA Engineer
Author
|
Submitted COMMENT review on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.6.0tag-push fired the newpublish.ymlquality gate which caughtoxfmtissues in the files I added for the proto provider — that's the gate doing its job. Auto-formatted viapnpm format; tests still pass (731/0 + 1 pre-existing skipped); format:check now clean.Why 0.6.1, not re-tag 0.6.0
Tag immutability is the rule we want — never re-publish the same version, even when an earlier attempt didn't actually reach npm. Treating tags as one-shot from day one is cheaper than figuring out the corner cases later. The
v0.6.0git tag stays as a historical "this attempt failed" marker;v0.6.1will be the first version actually on the registry.After merge
git tag v0.6.1 && git push --tags…publishes
@protolabsai/protopatch@0.6.1. Then workstacean Dockerfile swapsgithub:protoLabsAI/protoPatch→@protolabsai/protopatch@^0.6.1for proper version pinning.🤖 Generated with Claude Code