Skip to content

ci: route Linux runner through NSC_RUNNER variable#280

Closed
mabry1985 wants to merge 1 commit into
mainfrom
ci/namespace-runner-override
Closed

ci: route Linux runner through NSC_RUNNER variable#280
mabry1985 wants to merge 1 commit into
mainfrom
ci/namespace-runner-override

Conversation

@mabry1985

@mabry1985 mabry1985 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Route Linux runner through NSC_RUNNER

Part of the org-wide migration off Namespace toward self-hosted runners.

Converts hardcoded runs-on: namespace-profile-protolabs-linux to the override pattern already standard in the plugin repos:

runs-on: ${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }}

No behavior change today — with NSC_RUNNER unset, every job still runs on Namespace. Once self-hosted runners are live, setting the org-level NSC_RUNNER variable moves the entire fleet at once, with no further workflow edits.

Converted 6 workflow line(s) in this repo.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Improved workflow runner selection across CI, documentation, marketing deploy, and release preparation.
    • Workflows can now use a configurable runner when available, while still falling back to the existing default.
    • This makes the build and deploy setup more adaptable without changing the overall process.

Replaces hardcoded `runs-on: namespace-profile-protolabs-linux` with
`${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }}`, matching
the override pattern already standard across the plugin repos.

No behavior change: with NSC_RUNNER unset, jobs still run on Namespace.
This lets the whole fleet move to self-hosted runners by setting a single
org-level Actions variable instead of editing every workflow.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@protoquinn

protoquinn Bot commented Jun 24, 2026

Copy link
Copy Markdown

👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow.

@protoquinn protoquinn Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Audit — PR #280 | ci: route Linux runner through NSC_RUNNER variable

VERDICT: WARN


CI Status

  • Verify workspace config: queued
  • Lint: queued

⏳ Non-terminal — re-review will land when CI completes.

Diff Review

  • 6 single-line changes across 4 workflow files (ci.yml, docs.yml, marketing-deploy.yml, prepare-release.yml)
  • Uniform pattern: runs-on: namespace-profile-protolabs-linuxruns-on: ${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }}
  • Fallback preserves existing behavior — no behavioral change with NSC_RUNNER unset
  • Pattern matches the org-wide migration standard seen in plugin repos

Observations

  • LOW: Clawpatch structural review skipped — checkout cache couldn't resolve branch ref. Trivial diff (6 lines, uniform pattern) makes this low risk.
  • No unresolved CodeRabbit threads
  • No defects, anti-patterns, or security concerns in the diff itself

— Quinn, QA Engineer

@protoquinn

protoquinn Bot commented Jun 24, 2026

Copy link
Copy Markdown

Submitted COMMENT review on #280.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6ecafab3-7d6f-43ec-b832-2bed7e20fbed

📥 Commits

Reviewing files that changed from the base of the PR and between d2bfce0 and 22d376f.

📒 Files selected for processing (4)
  • .github/workflows/ci.yml
  • .github/workflows/docs.yml
  • .github/workflows/marketing-deploy.yml
  • .github/workflows/prepare-release.yml

Walkthrough

Four GitHub Actions workflow files (ci.yml, docs.yml, marketing-deploy.yml, prepare-release.yml) replace the hardcoded runner label namespace-profile-protolabs-linux with a dynamic expression ${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }} on six runs-on lines. No other job logic is changed.

Changes

Configurable runner via vars.NSC_RUNNER

Layer / File(s) Summary
Runner label made configurable in all workflow jobs
.github/workflows/ci.yml, .github/workflows/docs.yml, .github/workflows/marketing-deploy.yml, .github/workflows/prepare-release.yml
All six runs-on fields are changed from the fixed string namespace-profile-protolabs-linux to ${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }}, covering the workspace-config, lint, test, build, deploy, and prepare jobs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: CI workflows now route Linux runners through NSC_RUNNER.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/namespace-runner-override

Comment @coderabbitai help to get the list of available commands.

@protoquinn protoquinn Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI terminal-green, no blockers on prior review — auto-approving on green (#748).

@protoquinn

protoquinn Bot commented Jul 4, 2026

Copy link
Copy Markdown

Quinn Bug Triage — Closing as stale (not_planned)

This PR was approved and CI-green on June 24 (10 days stale) but was never merged. The change (CI runner override via NSC_RUNNER) is straightforward and safe, but if it's no longer desired, leaving it open creates noise in the pipeline.

Please reopen if this change is still needed.

@protoquinn protoquinn Bot closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant