ci: route Linux runner through NSC_RUNNER variable#280
Conversation
Replaces hardcoded `runs-on: namespace-profile-protolabs-linux` with
`${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }}`, matching
the override pattern already standard across the plugin repos.
No behavior change: with NSC_RUNNER unset, jobs still run on Namespace.
This lets the whole fleet move to self-hosted runners by setting a single
org-level Actions variable instead of editing every workflow.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
There was a problem hiding this comment.
QA Audit — PR #280 | ci: route Linux runner through NSC_RUNNER variable
VERDICT: WARN
CI Status
- Verify workspace config: queued
- Lint: queued
⏳ Non-terminal — re-review will land when CI completes.
Diff Review
- 6 single-line changes across 4 workflow files (
ci.yml,docs.yml,marketing-deploy.yml,prepare-release.yml) - Uniform pattern:
runs-on: namespace-profile-protolabs-linux→runs-on: ${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }} - Fallback preserves existing behavior — no behavioral change with
NSC_RUNNERunset - Pattern matches the org-wide migration standard seen in plugin repos
Observations
- LOW: Clawpatch structural review skipped — checkout cache couldn't resolve branch ref. Trivial diff (6 lines, uniform pattern) makes this low risk.
- No unresolved CodeRabbit threads
- No defects, anti-patterns, or security concerns in the diff itself
— Quinn, QA Engineer
|
Submitted COMMENT review on #280. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughFour GitHub Actions workflow files ( ChangesConfigurable runner via
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Quinn Bug Triage — Closing as stale (not_planned)This PR was approved and CI-green on June 24 (10 days stale) but was never merged. The change (CI runner override via Please reopen if this change is still needed. |
Route Linux runner through
NSC_RUNNERPart of the org-wide migration off Namespace toward self-hosted runners.
Converts hardcoded
runs-on: namespace-profile-protolabs-linuxto the override pattern already standard in the plugin repos:No behavior change today — with
NSC_RUNNERunset, every job still runs on Namespace. Once self-hosted runners are live, setting the org-levelNSC_RUNNERvariable moves the entire fleet at once, with no further workflow edits.Converted 6 workflow line(s) in this repo.
🤖 Generated with Claude Code
Summary by CodeRabbit