chore(lint): migrate ESLint → biome 2.4.16#42
Merged
Conversation
Standardize on biome (matching the fleet reference, protoWorkstacean) instead of
ESLint 9. The prior config was just `@eslint/js` recommended on plain .mjs — a
clean swap.
- replace eslint + globals devDeps with @biomejs/biome 2.4.16 (pinned exact)
- biome.json: recommended rules, formatter disabled (no reformatting churn),
noTemplateCurlyInString off (this is a GitHub-Actions tooling repo — `${{ }}`
in strings is intentional, not a botched template literal). noConsole is NOT
enabled: the bin/*.mjs are CLIs whose console.* IS their output.
- `lint` script: `eslint .` → `biome lint .`
- delete eslint.config.js
- applied biome's safe + unsafe autofixes (useConst, useTemplate, useOptionalChain)
— all semantically identical (string-concat→template, let→const, &&→?.)
Verified: `npm run lint` clean (0 errors/warnings), `npm test` 52 pass / 0 fail,
`npm run smoke` OK.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
There was a problem hiding this comment.
QA Audit — PR #42 | chore(lint): migrate ESLint → biome 2.4.16
VERDICT: PASS
CI Status
- Lint + smoke test: queued (not yet terminal — re-review will follow once checks complete)
Diff Review
- Removes
eslint+globalsdevDeps; adds@biomejs/biome2.4.16 (pinned exact) - New
biome.json:recommendedrules, formatter disabled,noTemplateCurlyInStringoff — all appropriate for a GitHub-Actions tooling repo where${{ }}in strings is intentional noConsoleleft off — correct, asbin/*.mjsare CLIs whoseconsole.*is their output surface- Three
.mjsfiles: all changes are biome autofixes (let→const, string-concat→template literal,&&→?.) — semantically identical, no behavioral change eslint.config.jsdeleted
Observations
- MEDIUM (gap): CI not yet terminal — formal verdict will be issued on next pass once
Lint + smoke testcompletes. No reason to expect failure given the PR description reports cleannpm run lintandnpm test(52 pass / 0 fail). - All changes are mechanical linter swaps with zero risk of behavioral change.
— Quinn, QA Engineer
|
Submitted COMMENT review on #42. CI was still queued at time of review — I've flagged this as a MEDIUM gap (CI not terminal) and will issue a formal verdict (APPROVE / REQUEST_CHANGES) once the |
This was referenced Jun 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Standardizes release-tools on biome 2.4.16 instead of ESLint 9 — matching the fleet reference (protoWorkstacean, which just upgraded to biome 2.x). The previous setup was a minimal
@eslint/jsrecommended config on plain.mjs, so this is a clean swap.eslint+globalsdevDeps with@biomejs/biome2.4.16(pinned exact for reproducible CI linting)biome.json:recommendedrules, formatter disabled (no reformatting churn),noTemplateCurlyInStringoff — this is a GitHub-Actions tooling repo, so${{ }}inside strings is intentional, not a botched template literalnoConsoleintentionally NOT enabled —bin/*.mjsare CLIs whoseconsole.*is their output (unlike a server, where it'd be operational logging)lintscript:eslint .→biome lint .; deletedeslint.config.jsuseConst,useTemplate,useOptionalChain) — all semantically identical (string-concat→template literal,let→const,a && a.b→a?.b)Verification
npm run lint— clean (0 errors, 0 warnings)npm test— 52 pass / 0 failnpm run smoke— OK (all 5 bin entrypoints respond to--help)🤖 Generated with Claude Code