feat: vendor xterm.js — fully offline, no CDN (v0.2.0)#2
Merged
Conversation
xterm.js + the fit/web-links addons + xterm.css are now vendored under vendor/ and
served by the plugin at /plugins/terminal/static/{name} (whitelisted FileResponse,
no traversal). The view loads them BASE-prefixed via injected <script>/<link> and
reads the UMD globals (window.Terminal, window.FitAddon.FitAddon, …) — no jsDelivr.
capabilities.network is now [] — the terminal works airgapped/offline.
Tests: the static route serves the vendored files (+404 for non-whitelisted); the
view page references the local /static path and contains no CDN/https URL.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #2 | feat: vendor xterm.js — fully offline, no CDN (v0.2.0)
VERDICT: WARN (non-terminal CI — test queued; re-review on CI completion)
CI Status
- test: ⏳ queued
Diff Review
- Vendors xterm.js + fit/web-links addons + xterm.css under
vendor/, served via new/static/{name}route with a strict whitelist (_VENDOR_TYPESdict). No path traversal possible —nameis gated by dict membership before any filesystem access. - Version bumped 0.1.1 → 0.2.0 in both
pyproject.tomlandprotoagent.plugin.yaml(a test enforces lockstep). capabilities.networkflipped from["cdn.jsdelivr.net"]to[]— clean.
Observations
- GAP: Diff truncated at 471 lines — the view template (
PAGE) changes andvendor/xterm.jsare not visible in this review pass. Tests assert the PAGE references/plugins/terminal/static/and contains no CDN/https://URLs, which mitigates but doesn't eliminate the gap. - LOW: clawpatch structural review unavailable (repo not in project registry). Diff-based review only.
- SEC/LOW: The
/static/{name}whitelist is sound._VENDOR_TYPES.get(name)returnsNonefor any non-whitelisted name, including traversal attempts like../../../etc/passwd, blocking them beforePathresolution. ✅
— Quinn, QA Engineer
|
Submitted COMMENT review on #2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up A (offline). xterm.js + the fit/web-links addons + xterm.css are now vendored under
vendor/and served by the plugin at/plugins/terminal/static/{name}(whitelistedFileResponse, no traversal). The view loads them BASE-prefixed via injected<script>/<link>and reads the UMD globals (window.Terminal,window.FitAddon.FitAddon, …) — no jsDelivr.capabilities.networkis now[]; the terminal works airgapped/offline.Tests: the static route serves the vendored files (+404 for non-whitelisted); the view page references the local
/staticpath and contains no CDN/https://URL. 17 tests green.