Conversation
The view now runs several terminals in one panel: a tab bar (+ to add, × to close, double-click to rename, click to switch). Each tab owns its own xterm + FitAddon + WebSocket, and each WebSocket gets its own PTY shell — closing a tab kills only that shell. No backend change (one PTY per connection was already the model). The protoAgent theme is applied across all tabs and re-applied live on a re-theme; vendored assets + the bearer-gated WS are unchanged. Tests: view-contract now asserts the tab bar + the per-session lifecycle (newSession/closeSession/switchTo + the session registry). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #4 | feat: multi-session tabs (v0.4.0)
VERDICT: WARN
CI Status
- test: in_progress
Diff Review
- Version bumps (0.3.0 → 0.4.0) in
protoagent.plugin.yamlandpyproject.tomlare consistent view.pyrewrites the terminal view from single-session to multi-session tabs with per-tab xterm + WebSocket + PTY- New test (
test_view_page_has_multi_session_tabs) asserts tab bar DOM + session lifecycle symbols in PAGE - CSS restructured:
.tabs/.tabstyles added,.barcompacted,#termreplaced with#terms+.termpane
Observations
- GAP: diff truncated at 200/329 lines — the full JS session management implementation (
newSession,closeSession,switchTo, session registry, per-tab WS lifecycle) is not visible to the reviewer - GAP: clawpatch structural review unavailable — repo not in project registry
- MEDIUM: reconnect button (
#reconnect) removed from the bar; per-tab reconnect strategy is unclear from the visible diff. Confirm reconnect is handled per-tab in the truncated JS portion - LOW: test is a view-contract assertion (string presence in PAGE) — adequate for template structure but doesn't exercise runtime tab switching or WS lifecycle
— Quinn, QA Engineer
|
Submitted COMMENT review on #4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up C (tabs). The view runs several terminals in one panel: a tab bar (+ add, × close, double-click rename, click to switch). Each tab owns its own xterm + FitAddon + WebSocket, and each WebSocket gets its own PTY shell — closing a tab kills only that shell. No backend change (one PTY per connection was already the model).
The protoAgent theme is applied across all tabs and re-applied live on a re-theme; vendored assets + the bearer-gated WS are unchanged.
Tests: the view-contract now asserts the tab bar + per-session lifecycle (
newSession/closeSession/switchTo+ the session registry). 20 tests green.