Resolve Withdrawals/Deposits#121
Resolve Withdrawals/Deposits#121provinzio merged 5 commits intoprovinzio:match-fees-with-operationsfrom
Conversation
|
I see rebasing did not work as expected. One sec. |
jhoogstraat
force-pushed
the
resolve-deposits-2
branch
from
cf20350 to
081c395
Compare
| f"({match.platform}, {match.utc_time})" | ||
| ) | ||
|
|
||
| log.info("Finished matching") |
There was a problem hiding this comment.
This could just as well be a debug log.
jhoogstraat
force-pushed
the
resolve-deposits-2
branch
from
081c395 to
7426249
Compare
src/book.py
Outdated
| for op in sorted_ops: | ||
| # log.debug(op.utc_time) | ||
| if isinstance(op, tr.Withdrawal): | ||
| if not misc.is_fiat(op.change): |
There was a problem hiding this comment.
we also should check for other fiats. only config.FIAT hasn't to be monitored.
There was a problem hiding this comment.
What do you mean by other fiats? misc.is_fiat already checks if the currency is any possible currency in Fiat.
There was a problem hiding this comment.
Selling e.g. USD might be a taxable income for a German citizien (like selling BTC), because it's a foreign fiat currency. I think that, although this tool is for crypto taxation, we should notify about that and try to evaluate the taxes for that, too.
There was a problem hiding this comment.
what I meant by check other fiat currencies is, that we also should match deposit and withdrawals for other fiat currencies
|
Hey @jhoogstraat, thank you for your good and helpfull contribution. The deposit/withdrawal match is an important milestone for a correct tax evaluation. |
2 participants
This is the follow-up for #116.
Contains a simple algorithm which matches related withdrawals and deposits.
Deposits now have a
linkproperty containing a reference to the matching withdrawal.The algorithm checks that: