Skip to content

Multi Vcenter feature#54

Open
prsadhu-ms-idc wants to merge 17 commits into
generationfrom
MultiVcenter
Open

Multi Vcenter feature#54
prsadhu-ms-idc wants to merge 17 commits into
generationfrom
MultiVcenter

Conversation

@prsadhu-ms-idc
Copy link
Copy Markdown
Owner

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

$null = $PSBoundParameters.Remove('SiteName')

# Get the run as account Id.
$VMWarerunasaccountID = $vCenter.RunAsAccountId
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for vcenter null?

# Get the VCenter object.
$vcenterId = $discoveredVMwareMachine.VCenterId
$vCenterIdArray = $vcenterId.Split("/")
$vCenterName = $vCenterIdArray[10]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can there be util to extract subId/rgName/resourceName from an ArmID? Like we do in service. Using indices can be confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants