Fix unit type recognition when file edited using systemctl edit cmd#4
Open
RayJameson wants to merge 1 commit intopsacawa:masterfrom
Open
Fix unit type recognition when file edited using systemctl edit cmd#4RayJameson wants to merge 1 commit intopsacawa:masterfrom
systemctl edit cmd#4RayJameson wants to merge 1 commit intopsacawa:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I like your language server, it's very helpful for a newbie in systemd unit files.
This PR fixes problem when you edit/create unit file using
systemctl edit --fullcommandI want to point out that there is another bug, if you overriding service using
systemctl editcommand without--fullargument, it's opens something like~/.config/systemd/user/syncthing.service.d/.#override.confafc30fc0826930be. So figuring out unit type requires another approach.It requires more changes to fix this bug than this PR and I'm not sure if you would accept them