use qcng task_config inquiry#87
Open
loriab wants to merge 1 commit into
Open
Conversation
Owner
|
I would think we could accommodate this. I wonder if @AlexHeide 's string methods coming in are relevant to the solution, as they could involve energies/gradients running in parallel. |
Collaborator
Author
|
thanks, gtk. Yes, threading-wise I can see how strings methods make another layer of complication. The situation I described ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't a ready-to-merge PR; it's more of a discussion opener. MolSSI/QCEngine#402 pointed out that qcengine-driven optimizations aren't obeying the task_config (formerly local_options) ncores/memory/scratch/etc. user settings passed into
qcng.compute_procedure()for user control. He has a little script showing the cores psi4 (the common gradient-generator) is getting, and optking is always giving psi4 single-thread, which I can see is deliberately set by optking topsi4.get_num_threads().I know that all the ways and means of commencing and routing among psi4/other-gradient-generators/optking/qcengine are complex, and the current setup probably was designed to play nicely with psi4 as top-level in some way. So I wonder if design considerations rule out this PR's suggestion or if there's a way to make it work.
No hurry on this -- just lodging the issue in the right place.