Conversation
Stock headless chrome running as root in a CI container needs --no-sandbox (the default sandbox refuses to start), --disable-dev-shm-usage (small /dev/shm in containers), and an isolated --user-data-dir (first-run profile waits); without these the renderer can hang until the 20s cap, which surfaced as a flaky timeout in test_render_card_chrome_produces_png on the 3.12 CI leg (run 33490519437, then 33499015053 with the flags alone - the same test passes on other legs and on reruns). On timeout, retry once with a 60s window before giving up; real failures (non-zero exit, empty screenshot) still surface immediately. Desktop behavior is unchanged: same screenshot path, same virtual-time budget.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone follow-up to the corpus-verify restore (now PR-only content on
fix/restore-corpus-verify-cli): keeps the CI-hardening changes separate so each PR is reviewable on its own.Problem:
tests/test_session_card.py::test_render_card_chrome_produces_pngflaked on the 3.12 CI leg —chrome render timed out after 20s(run 33490519437; recurred on 33499015053 with flags alone; passed on other legs, on the PR run, and on reruns). The renderer launches stock headless Chrome as root in a CI container, which can hang on sandbox/first-run/small-/dev/shmuntil the cap.Fix:
--no-sandbox,--disable-dev-shm-usage, isolated--user-data-dir, first-run suppressorsTest plan:
python -m py_compile wallbreaker/tools/session_card.pyclean; branch CI green on both legs (run 33499514813 pattern); flake history documented above.