Support TCN input and dump preprocessed TCN - #30
Open
multivvac wants to merge 2 commits into
Open
Conversation
ptal
requested changes
May 5, 2026
Adds direct .tcn input via lala-parsing's parse_tcn() and a -dump_preprocessed_tcn flag that emits the post-preprocessing ternary constraint network (variables + bytecodes) in the TCN text format.
Replaces the inline serialization loop in dump_preprocessed_tcn_if_needed with a call to lala::write_preprocessed_tcn(), keeping only the file IO and config handling on the turbo side.
ptal
approved these changes
May 5, 2026
ptal
left a comment
ptal
left a comment
Owner
There was a problem hiding this comment.
looks fine, i'll wait the update in lala-parsing before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds direct .tcn input via lala-parsing's parse_tcn() and a -dump_preprocessed_tcn flag that emits the post-preprocessing ternary constraint network in the TCN text format.
Depends on: