Update egg-windrose.json#526
Open
nimauria wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several Windrose-specific compatibility issues in the egg configuration.
Changes:
UEngine::LoadMap Load map complete0/1handling to explicittrue/falseMAX_PLAYERSas an integer instead of a generic stringWhy:
Windrose reads values from
R5/ServerDescription.json, and several fields are more reliable when passed in the format the game expects rather than generic panel-style boolean handling. This PR keeps the egg structure intact while correcting value formats and validation for the game’s config.The current egg uses panel boolean-style
0/1defaults and validation for settings that are written directly intoServerDescription.json. For Windrose, explicittrue/falsevalues are more reliable for these config fields and avoid values being ignored or mishandled by the game.Checklist for all submissions