fix(windrose): allow configuring P2P proxy address#536
Open
zappbrannigan34 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the Windrose
P2P_PROXY/P2pProxyAddressvariable configurable instead of hard-locking it to127.0.0.1.The current egg sets:
required|string|in:127.0.0.1
and marks the variable as not user-editable. This can break invite-code / ICE connections on host-network VPS setups, because Windrose uses P2pProxyAddress as the IP address for P2P/ICE listening sockets.
The official Windrose dedicated server guide describes P2pProxyAddress as the “IP address used for listening sockets” and shows a non-loopback LAN IP in the example config.
Tested
Tested on a Pterodactyl Windrose server using host networking.
Before changing P2P_PROXY:
P2P_PROXY=127.0.0.1
The server registered successfully, but player connection through invite code failed during ICE candidate gathering:
Cannot resolve addresses for host . Status message Host not found.
Error on getting local ICE candidates for BL.
After changing the deployed egg variable:
P2P_PROXY=<server public/allocation IP>
invite-code connection worked.
Changes
Renamed P2P PROXY to P2P Proxy Address.
Updated the variable description.
Made P2P_PROXY viewable/editable.
Removed the in:127.0.0.1 validation restriction.
Added README troubleshooting notes for invite-code / ICE failures.