Repository navigation
chore(deps): add types-PyYAML to dev extras for mypy - #184
Merged
Merged
Conversation
mypy's `ignore_missing_imports = true` suppresses import-not-found but NOT import-untyped, which fires when stubs exist on PyPI but are uninstalled. Two in-flight branches hit it on `import yaml`: - wt/t35-unified ondine/mcp/server.py:31 - wt/t6-plan ondine/orchestration/intent/planner.py:134 Landing the stub package on main removes that error from both before rebase. Verified: mypy clean (115 files), 967 unit tests pass.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe development optional dependency group now includes ChangesYAML typing dependency
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ptimizeroracle
pushed a commit
that referenced
this pull request
Jul 30, 2026
Resolves two conflicts: - pyproject.toml: keep this branch's upgraded dev toolchain (pytest 9.1.1, ruff 0.15.21, mypy 2.2.0, ...) AND main's types-PyYAML stubs from #184. - uv.lock: regenerated from scratch with `uv lock` rather than textually merged — a 3-way-merged lockfile is internally inconsistent. Also refreshes this branch against README/enrich/plan work merged in #174 #175 #176 #181 #183 #184.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the mypy failures on two in-flight branches.
mypy's
ignore_missing_imports = true(already set in[tool.mypy]) suppressesimport-not-foundbut notimport-untyped— the latter fires when stubs arepublished on PyPI but not installed. Both in-flight branches trip it on
import yaml:wt/t35-unifiedondine/mcp/server.py:31wt/t6-planondine/orchestration/intent/planner.py:134Landing the stub package here removes that error from both before they rebase,
rather than each branch fixing it independently and conflicting on
pyproject.toml.Verified locally on this branch:
mypy ondine/→ Success: no issues found in 115 source filespytest tests/unit/→ 967 passed, 12 skippedNote:
uv.lockis regenerated (addstypes-pyyaml 6.0.12.20260724). #180 and #182also touch
uv.lockand will needuv lockre-run after rebasing onto this — nevera hand-merge.
Summary by CodeRabbit