Skip to content

chore(deps): add types-PyYAML to dev extras for mypy - #184

Merged
ptimizeroracle merged 1 commit into
mainfrom
chore/mypy-yaml-stubs
Jul 30, 2026
Merged

ptimizeroracle merged 1 commit into
mainfrom
chore/mypy-yaml-stubs

Conversation

@ptimizeroracle

@ptimizeroracle ptimizeroracle commented Jul 30, 2026 •

Copy link
Copy Markdown
Owner

Unblocks the mypy failures on two in-flight branches.

mypy's ignore_missing_imports = true (already set in [tool.mypy]) suppresses
import-not-found but not import-untyped — the latter fires when stubs are
published on PyPI but not installed. Both in-flight branches trip it on import yaml:

Branch PR Error
wt/t35-unified #180 ondine/mcp/server.py:31
wt/t6-plan #181 ondine/orchestration/intent/planner.py:134

Landing the stub package here removes that error from both before they rebase,
rather than each branch fixing it independently and conflicting on pyproject.toml.

Verified locally on this branch:

  • mypy ondine/ → Success: no issues found in 115 source files
  • pytest tests/unit/ → 967 passed, 12 skipped

Note: uv.lock is regenerated (adds types-pyyaml 6.0.12.20260724). #180 and #182
also touch uv.lock and will need uv lock re-run after rebasing onto this — never
a hand-merge.

Summary by CodeRabbit

  • Chores
    • Improved development tooling with enhanced type support for YAML configuration files.

mypy's `ignore_missing_imports = true` suppresses import-not-found but NOT
import-untyped, which fires when stubs exist on PyPI but are uninstalled.
Two in-flight branches hit it on `import yaml`:
  - wt/t35-unified  ondine/mcp/server.py:31
  - wt/t6-plan      ondine/orchestration/intent/planner.py:134

Landing the stub package on main removes that error from both before rebase.

Verified: mypy clean (115 files), 967 unit tests pass.
@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fa9eb1c6-61c7-4548-8f00-77eb4d6ce048

📥 Commits

Reviewing files that changed from the base of the PR and between cdc14f1 and e6d6268.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

The development optional dependency group now includes types-PyYAML>=6.0.12 to provide YAML typing stubs.

Changes

YAML typing dependency

Layer / File(s) Summary
Development dependency update
pyproject.toml
Adds types-PyYAML>=6.0.12 to the development optional dependencies.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding types-PyYAML to dev extras to support mypy.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/mypy-yaml-stubs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ptimizeroracle
ptimizeroracle merged commit 7f21c2e into main Jul 30, 2026
32 of 34 checks passed
@ptimizeroracle
ptimizeroracle deleted the chore/mypy-yaml-stubs branch July 30, 2026 11:48
ptimizeroracle pushed a commit that referenced this pull request Jul 30, 2026
Resolves two conflicts:
- pyproject.toml: keep this branch's upgraded dev toolchain (pytest 9.1.1,
  ruff 0.15.21, mypy 2.2.0, ...) AND main's types-PyYAML stubs from #184.
- uv.lock: regenerated from scratch with `uv lock` rather than textually
  merged — a 3-way-merged lockfile is internally inconsistent.

Also refreshes this branch against README/enrich/plan work merged in
#174 #175 #176 #181 #183 #184.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant