Stable error codes, audit manifest migration tests, and full-binary release smoke tests - #942
Merged
Merged
Conversation
Introduces a stable ErstInternalError code plus WrapInternal() for command-facing internal failures that previously returned bare, unwrapped errors (e.g. note-add's ID generation path), and adds a requireErstError/requireErstErrorCode test helper so command tests can assert that returned errors are ErstError values instead of leaking unclassified errors. Ref pugsley76#762.
Session, config, trace, and bundle artifacts already have legacy migration and unsupported-version tests, but the audit segment manifest's schema_version contract (forward-loading a pre-versioning manifest, rejecting a manifest declaring an unrecognized version) had no direct coverage. Add tests pinning both behaviors plus a ReadManifest/WriteManifestAtomic roundtrip check. Ref pugsley76#872.
verify-release.sh previously only smoke-tested the binary matching the current host OS/arch. Extend it to attempt every EXPECTED artifact via a native run or an available emulator (wine for Windows, qemu-*-static for foreign Linux arches), running version/help/demo/dry-run/JSON commands per artifact. When no runner exists for a platform its commands are reported as SKIP-UNAVAILABLE rather than FAIL, and per-command metadata (artifact, command, exit code, output excerpt) is written to dist/release/smoke-results.log. All commands used are offline and require no network, credentials, or deployed contracts. Ref pugsley76#877.
|
@lonerthefirst3-sudo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go test ./internal/cmd/... ./internal/errors/... ./internal/audit/...bash scripts/verify-release.sh dist/releaseagainst a built release directoryCloses #762
Closes #872
Closes #877