-
Notifications
You must be signed in to change notification settings - Fork 0
add package.json with postinstall canary script #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pullfrog
wants to merge
76
commits into
main
Choose a base branch
from
pullfrog/add-test-package-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
9be3fdd
add package.json with postinstall canary script
pullfrog[bot] 15b1549
add package.json with postinstall canary script
pullfrog[bot] ca360b0
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] d9770c5
add package.json for dependency install test
pullfrog[bot] 3712e28
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] bbd9453
add package.json with postinstall canary script
pullfrog[bot] 0ddf13a
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 8a554cd
add package.json for dependency installation test
pullfrog[bot] 2e6b843
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] e92bf9e
add package.json for dependency installation test
pullfrog[bot] 0cc6d7c
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] cde1787
add test package.json with postinstall canary script
pullfrog[bot] dd73bba
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 56aec62
add package.json with postinstall canary script
pullfrog[bot] 368cb29
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 660817d
add package.json with postinstall canary script
pullfrog[bot] 6fb2e92
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 25814ad
add package.json with postinstall canary script
pullfrog[bot] 0a27b13
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 1ba43c4
Add package.json for dependency installation test
pullfrog[bot] 4a49e0c
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 8e50d43
add package.json with postinstall canary script
pullfrog[bot] 8c52cd9
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 56e720e
add package.json with postinstall canary script
pullfrog[bot] cba0168
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] f57e9c1
add package.json with postinstall canary script
pullfrog[bot] 361bdc8
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 84f80af
add package.json with postinstall canary script
pullfrog[bot] 8eabe78
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 5a3e66f
add test package.json with postinstall canary script
pullfrog[bot] 1cd894e
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 1f70857
add test package.json with postinstall canary script
pullfrog[bot] 0fe99cc
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 0fa754a
add package.json for dependency installation test
pullfrog[bot] bbe3dec
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 26e5b23
add package.json with postinstall canary script
pullfrog[bot] c095434
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] cd3a4bb
add package.json with postinstall test script
pullfrog[bot] 548ad0c
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 82606af
add test package.json with postinstall canary script
pullfrog[bot] 0b9f551
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] cd0275b
add package.json with postinstall canary script
pullfrog[bot] 8a280ac
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] c688e42
add package.json with postinstall canary script
pullfrog[bot] 0f0d063
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 4c56018
add package.json with postinstall canary script
pullfrog[bot] 7b34cf4
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 4c56bd9
add package.json with postinstall canary script
pullfrog[bot] 651e580
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 6e00d35
add package.json with postinstall canary script
pullfrog[bot] a21d333
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 192536b
add package.json with postinstall canary script
pullfrog[bot] c8bd175
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 8eaa61d
add test package.json with postinstall canary script
pullfrog[bot] 1339b8d
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 12f3b75
add package.json for dependency install test
pullfrog[bot] 22218ed
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 5018af0
add test package.json with postinstall canary script
pullfrog[bot] 4a452c3
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] bb40893
add test package.json with postinstall canary script
pullfrog[bot] 4159c9f
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 27a8e88
add package.json with postinstall canary script
pullfrog[bot] 5627c2d
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 4429946
add package.json for dependency installation test
pullfrog[bot] f5a3b15
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] 17e322c
add package.json with postinstall canary script
pullfrog[bot] 2da1624
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] de4e3ce
pr-assets: homepage redesign screenshots for pullfrog/app PR #974
e7cd04e
add package.json for dependency installation test
pullfrog[bot] 64cae7b
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] efc5b8c
pr-974 v2: v2-hero.png
colinhacks 3a90654
pr-974 v2: v2-capability-grid.png
colinhacks 3f1dfe2
pr-974 v2 screenshots (skill-grounded redesign pass)
7cd8635
pr-974 v3 screenshots (review-fix pass)
2afa55a
add package.json for dependency installation test
pullfrog[bot] 75c96d4
Merge remote-tracking branch 'origin/pullfrog/add-test-package-json' …
pullfrog[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| { | ||
| "name": "test-repo", | ||
| "private": true, | ||
| "type": "module", | ||
| "name": "test-pkg", | ||
| "version": "1.0.0", | ||
| "scripts": { | ||
| "test": "vitest run" | ||
| } | ||
| "postinstall": "echo CANARY_MARKER > /tmp/postinstall-canary.txt" | ||
| }, | ||
| "dependencies": {} | ||
| } | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test fixture overwrites project's real package.json configuration
High Severity
This change replaces the repository's real
package.json(which had"private": true,"type": "module", and a"test": "vitest run"script) with a postinstall canary test fixture. The existingtest/math.test.tsstill imports fromvitest, so tests can no longer run. Removing"type": "module"breaks ESM resolution for the TypeScript sources, and removing"private": truerisks accidental npm publication. This looks like test fixture content that belongs in a subdirectory rather than at the project root.Reviewed by Cursor Bugbot for commit 0ddf13a. Configure here.