Skip to content

Comments

Bump snitch#83

Open
Lore0599 wants to merge 8 commits intodevelfrom
bump_snitch
Open

Bump snitch#83
Lore0599 wants to merge 8 commits intodevelfrom
bump_snitch

Conversation

@Lore0599
Copy link
Contributor

Bump Snitch Cluster

This PR bumps the Snitch cluster, following the update performed in #81 (@Paolo309).

It also updates the integration of the Snitch cluster within the top-level make flow.

Main Changes

Dependencies

  • Updated Bender.yml and corresponding .lock files to align with upstream dependencies.
  • Notable change: switched axi to https://github.com/colluca/axi (branch multicast).

chimera_cluster.sv

  • Added a TCDM interface (currently left unconnected).

Make flow

  • Renamed snitch-hw-init to sn-hw-all, consistent with the upstream Snitch cluster documentation.
  • Integrated the chs-sim-all target into chim-sim.

Python environment

  • Added a pyproject.toml file to manage Python dependencies.
  • Fixed the Bender version in iis-env to 0.29.1.

Copy link

@colluca colluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, otherwise I think the Snitch integration is solid

Comment on lines +34 to +35
# Use the snitch toolchain to generate the cluster bootrom
-include $(SN_ROOT)/sw/toolchain.mk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're not using the internal bootrom, you probably don't need all this.

Comment on lines +20 to +23
revision: 8e04779f341eb2c89412aae92223a292beef487e
version: null
source:
Git: https://github.com/pulp-platform/axi.git
Git: https://github.com/colluca/axi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colluca Is there a plan to upstream the axi multicast branch? I think we should try to avoid using forks in our upstream repos if possible.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the famous multicast PR (pulp-platform/axi#398). Ball is in Michael's court again since a few weeks, will ping him again.

dependencies:
register_interface: { git: "https://github.com/pulp-platform/register_interface.git", version: 0.4.3 }
axi: { git: "https://github.com/pulp-platform/axi.git", version: 0.39.2 }
axi: { git: https://github.com/colluca/axi, rev: multicast }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"flatdict",
"json5",
"peakrdl",
"peakrdl-rawheader @ git+https://github.com/colluca/PeakRDL-rawheader.git@7b8dbc9ad5854dc1cdaf36d4ea024c29ffb00a4c",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from the current PyPi release v0.2.2?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this can be bumped, those developments should have since been merged, and should be included in the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants