Skip to content

Fix misuse of gpg_verify#2330

Open
dralley wants to merge 2 commits intopulp:mainfrom
dralley:fix-gpg
Open

Fix misuse of gpg_verify#2330
dralley wants to merge 2 commits intopulp:mainfrom
dralley:fix-gpg

Conversation

@dralley
Copy link
Copy Markdown
Contributor

@dralley dralley commented Apr 21, 2026

It was trying to verify a detached signature without providing the detached data. PySequoia is stricter about this than gpg.

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

It was trying to verify a detached signature without providing the
detached data. PySequoia is stricter about this than gpg.
)

gpg_verify(self.public_key, signed["signature_path"])
gpg_verify(self.public_key, signed["signature_path"], detached_data=manifest_file.name)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a detached signature, but we were asking it to validate the signature without also providing the signed data. I guess gpg was fine with that or tolerated it, but pysequoia is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants