Fix issues introduced by gnupg removal patch#7602
Open
Conversation
Contributor
Author
|
@jitka This should fix plugins |
Restore python-gnupg to functional tests only - not worth trying to replace this fixture like-for-like Fix an issue with inlined signatures. We should only parse the sig separately in the detached case.
dralley
changed the title
dralley
changed the title
dralley
commented
Apr 16, 2026
| key_file.write_text(private_key_data) | ||
|
|
||
| from pysequoia import Cert | ||
| gpg = gnupg.GPG(gnupghome=signing_gpg_homedir_path) |
Contributor
Author
There was a problem hiding this comment.
We can use python-gnupg in functional tests, it's fine for now. Not worth trying to replace with layers of compat right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Checklist
See: Pull Request Walkthrough