Skip to content

fix(component): compile kiln-component standalone + fix the isolated build (SR-54, partial #446) - #462

Merged
avrabe merged 1 commit into
mainfrom
fix/446-kiln-component-isolated-build
Jul 22, 2026
Merged

fix(component): compile kiln-component standalone + fix the isolated build (SR-54, partial #446)#462
avrabe merged 1 commit into
mainfrom
fix/446-kiln-component-isolated-build

Conversation

@avrabe

@avrabe avrabe commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

The bug (#446)

cargo check -p kiln-component failed to compile on clean main. default = ["kiln-runtime/std"] enabled the dependency's std but never kiln-component's own std/kiln-execution features, so cfg-gated items (link_imports, call_direct_export/call_command_entry, the runtime_engine field) vanished. Only workspace feature unification hid it — so CI stayed green while a consumer depending on kiln-component alone got a build failure.

Fix

default = ["std", "kiln-execution"]. kiln-execution is a pure cfg flag (kiln-execution = [], no deps), so no dependency graph changes — it just enables by default the execution surface a standalone consumer needs, aligning the isolated build with the workspace build.

Verified

  • cargo check -p kiln-component (bare, default features) now compiles;
  • cargo check --workspace still green (unification unaffected);
  • consumers unchanged: kilnd 6+4+13 pass, kiln-wasi lib 68 pass.

Scope — honest boundary

This fixes the lib isolated build (the #446 headline). It does not fix the crate's test/example targets, which are separately and more deeply rotten — cargo test -p kiln-component --no-run still fails with ~47 type mismatches plus references to removed APIs (execute_start, Component.options, ExternType::Function, task_manager, async_). That's a larger fix-or-delete cleanup of stale tests; I've left #446 open with a remaining: note for it rather than pretend this closes it.

Accumulating toward v0.4.3 (rivet SR-54).

🤖 Generated with Claude Code

`default = ["kiln-runtime/std"]` enabled the DEPENDENCY's std but never
kiln-component's OWN `std`/`kiln-execution` features, so the cfg-gated surface
(link_imports, call_direct_export/call_command_entry, the runtime_engine field)
vanished under an isolated build. `cargo check -p kiln-component` failed on
clean main; only workspace feature unification hid it, so CI stayed green (#446).

Fix: `default = ["std", "kiln-execution"]`. `kiln-execution` is a pure cfg flag
(`kiln-execution = []`, no deps), so this changes no dependency graph — it just
turns on by default the execution surface a standalone consumer needs, aligning
the isolated build with the workspace build.

Verified:
  - `cargo check -p kiln-component` (bare, default features) now compiles;
  - `cargo check --workspace` still green (unification unaffected);
  - consumers unchanged: kilnd 6+4+13 pass, kiln-wasi lib 68 pass.

SCOPE: fixes the LIB isolated build (the #446 headline). Does NOT fix the
crate's TEST/EXAMPLE targets, which are separately + more deeply rotten
(`cargo test -p kiln-component --no-run` still fails: ~47 type mismatches +
removed-API refs — execute_start, Component.options, ExternType::Function,
task_manager, async_). That larger fix-or-delete cleanup is the remaining
half of #446.

Implements: SR-54
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FcTUZgts331Z1TK3q8YBQj
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@github-actions

Copy link
Copy Markdown

🔍 Build Diagnostics Report

Summary

Metric Base Branch This PR Change
Errors 0 0 0
Warnings 5 5 0

🎯 Impact Analysis

Issues in Files You Modified

  • 0 new errors introduced by your changes
  • 0 new warnings introduced by your changes
  • 0 total errors in modified files
  • 0 total warnings in modified files
  • 0 files you modified

Cascading Issues (Your Changes Breaking Other Files)

  • 0 new errors in unchanged files
  • 0 new warnings in unchanged files
  • 0 unchanged files now affected

Note: "Cascading issues" are errors in files you didn't modify, caused by your changes (e.g., breaking API changes, dependency issues).

✅ No Issues Detected

Perfect! Your changes don't introduce any new errors or warnings, and don't break any existing code.


📊 Full diagnostic data available in workflow artifacts

🔧 To reproduce locally:

# Install cargo-kiln
cargo install --path cargo-kiln

# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning

@avrabe
avrabe merged commit 4c0fb50 into main Jul 22, 2026
21 checks passed
@avrabe
avrabe deleted the fix/446-kiln-component-isolated-build branch July 22, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant