fix(component): compile kiln-component standalone + fix the isolated build (SR-54, partial #446) - #462
Merged
Merged
Conversation
`default = ["kiln-runtime/std"]` enabled the DEPENDENCY's std but never kiln-component's OWN `std`/`kiln-execution` features, so the cfg-gated surface (link_imports, call_direct_export/call_command_entry, the runtime_engine field) vanished under an isolated build. `cargo check -p kiln-component` failed on clean main; only workspace feature unification hid it, so CI stayed green (#446). Fix: `default = ["std", "kiln-execution"]`. `kiln-execution` is a pure cfg flag (`kiln-execution = []`, no deps), so this changes no dependency graph — it just turns on by default the execution surface a standalone consumer needs, aligning the isolated build with the workspace build. Verified: - `cargo check -p kiln-component` (bare, default features) now compiles; - `cargo check --workspace` still green (unification unaffected); - consumers unchanged: kilnd 6+4+13 pass, kiln-wasi lib 68 pass. SCOPE: fixes the LIB isolated build (the #446 headline). Does NOT fix the crate's TEST/EXAMPLE targets, which are separately + more deeply rotten (`cargo test -p kiln-component --no-run` still fails: ~47 type mismatches + removed-API refs — execute_start, Component.options, ExternType::Function, task_manager, async_). That larger fix-or-delete cleanup is the remaining half of #446. Implements: SR-54 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FcTUZgts331Z1TK3q8YBQj
|
🔍 Build Diagnostics ReportSummary
🎯 Impact AnalysisIssues in Files You Modified
Cascading Issues (Your Changes Breaking Other Files)
✅ No Issues DetectedPerfect! Your changes don't introduce any new errors or warnings, and don't break any existing code. 📊 Full diagnostic data available in workflow artifacts 🔧 To reproduce locally: # Install cargo-kiln
cargo install --path cargo-kiln
# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug (#446)
cargo check -p kiln-componentfailed to compile on clean main.default = ["kiln-runtime/std"]enabled the dependency's std but never kiln-component's ownstd/kiln-executionfeatures, so cfg-gated items (link_imports,call_direct_export/call_command_entry, theruntime_enginefield) vanished. Only workspace feature unification hid it — so CI stayed green while a consumer depending on kiln-component alone got a build failure.Fix
default = ["std", "kiln-execution"].kiln-executionis a pure cfg flag (kiln-execution = [], no deps), so no dependency graph changes — it just enables by default the execution surface a standalone consumer needs, aligning the isolated build with the workspace build.Verified
cargo check -p kiln-component(bare, default features) now compiles;cargo check --workspacestill green (unification unaffected);Scope — honest boundary
This fixes the lib isolated build (the #446 headline). It does not fix the crate's test/example targets, which are separately and more deeply rotten —
cargo test -p kiln-component --no-runstill fails with ~47 type mismatches plus references to removed APIs (execute_start,Component.options,ExternType::Function,task_manager,async_). That's a larger fix-or-delete cleanup of stale tests; I've left #446 open with aremaining:note for it rather than pretend this closes it.Accumulating toward v0.4.3 (rivet SR-54).
🤖 Generated with Claude Code