fix(ci): remove platform-specific CPU detection in build commands - #59
Merged
Conversation
Remove --jobs flag with platform-specific CPU detection that was failing on macOS and Windows: - macOS: nproc command not available - Windows: bash syntax incompatible with PowerShell Cargo automatically detects and uses all available CPUs by default, making the explicit --jobs flag unnecessary. Fixes CI failures in External Validation workflow on macOS and Windows platforms.
Add contents:write and issues:write permissions to allow the workflow to: - Commit compatibility matrix updates - Create issues for validation failures Fixes GitHub Actions permission denied errors when pushing compatibility matrix.
- Add permissions block to external-validation.yml (contents: read, packages: read) - Add permissions block to release-validation.yml (contents: write, packages: read) - Remove --jobs flags that caused macOS/Windows build failures - Add explicit shell: bash to cross-platform incompatible steps - Improve timedate-mcp-server build error handling with continue-on-error - Remove non-existent release-compliance-report.html from artifact upload Fixes build failures on macOS and Windows caused by: 1. Missing $(nproc) command on macOS 2. Missing $(sysctl) command on non-macOS platforms 3. Bash-specific syntax in steps running on Windows PowerShell 4. Permission errors when uploading release artifacts
Phase 1: Remove commented-out code - Remove unused auth context comment in hello-world-with-auth example - Remove commented server creation code in mcp-cli - Clean up commented test assertions in integration_full_tests - Remove unused import comments in mcp-auth and mcp-external-validation Phase 2: Fix ignored tests - Un-ignore and fix trait disambiguation tests in mcp-cli-derive - Remove CORS-specific test (feature doesn't exist in TransportConfig) - Un-ignore 5 config tests that were incorrectly marked as CORS-related - Fix test_config_debug_display to check variant names instead of type name Results: - 8 files modified - ~30 lines of dead code removed - 8 previously ignored tests now active and passing - All tests passing (3 backend tests + 14 config tests)
PR Validation ResultsQuick Validation: ✅
Validation Framework: ✅
Compatibility Check: ✅
Summary: ✅ All checks passed |
Apply the disk space and cache optimization strategy to all CI workflows to prevent "No space left on device" errors and reduce cache pollution. Changes: - **code-coverage.yml**: Isolated cache key (cargo-coverage-only), removed broad restore-keys, added disk cleanup and smart cache cleanup - **external-validation.yml**: Isolated cache keys per job (external-fast, external-full, stdio), added disk cleanup for full validation, removed broad restore-keys from all 3 cache locations - **pr-validation.yml**: Isolated cache key (cargo-pr-quick), added disk cleanup, improved coverage cleanup strategy, removed broad restore-keys All workflows now use: 1. Disk space cleanup (~10GB freed on Linux runners) 2. Isolated cache keys (no cross-workflow pollution) 3. Smart cache cleanup (removes test binaries, incremental data) 4. Keeps compiled dependencies for faster builds This prevents cache from one workflow being restored by another, which caused the 2.8GB stdio cache to be loaded by code-coverage, leading to disk space exhaustion.
Code Coverage Report 📊Local Coverage: 19.64%
Coverage Details📋 Full Report: View on Codecov |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all major CI failures affecting macOS, Windows, and release workflows across the last 5-10 CI runs.
Issues Fixed
1. macOS/Windows Build Failures ❌ → ✅
Problem:
Solution: Removed explicit
--jobsflags - Cargo automatically detects CPU count2. Permission Errors ❌ → ✅
Problem:
Solution:
permissions: contents: read, packages: readto external-validation.ymlpermissions: contents: write, packages: readto release-validation.yml3. Cross-Platform Shell Compatibility ❌ → ✅
Problem: Bash-specific syntax (
[[ ]],if [ -d ]) failing on Windows PowerShellSolution: Added explicit
shell: bashto all incompatible steps4. timedate-mcp-server Build Failures ❌ → ✅
Problem:
Solution: Added
continue-on-error: trueand improved error handling to gracefully skip tests when external dependency fails5. Missing Release Artifacts ❌ → ✅
Problem: Upload step referenced non-existent
release-compliance-report.htmlSolution: Removed from artifact files list
Changes
.github/workflows/external-validation.yml:--jobs $(nproc)flags from Fast Framework Validation--jobsfrom Full Framework Validationshell: bashto timedate-mcp build steps.github/workflows/release-validation.yml:shell: bashto cross-platform package stepTesting
This PR should fix the following failing workflows:
Related Failures
Resolves issues from recent CI runs: