docs(337): make the verification claim accurate (relabel + narrow) - #350
Merged
Conversation
The flat always-green `Formally_Verified` badge and the "every transformation carries mechanized proofs covering parsing, resolution, merging, and adapter correctness" tagline overstated the actual evidence (grounded in proofs/STATUS.md + abi_proofs.rs): - Kani harnesses (abi/resolver/merger) are VERIFICATION SUCCESSFUL LOCALLY (SR-40) but NOT gated in CI (shared runners lack the Kani toolchain); some ABI size/align + aggregate-padding contracts fell back to unit tests. - Rocq: 350 closed proofs on resolver/merger/adapter/spec (real, substantial), but parser/rewriter/segments/attestation are placeholders, orchestration is unproven, semantic preservation is a FORWARD simulation only, and one FACT adapter lemma is Admitted — so "every transformation … behaves identically" overstates. Fix (claim-verification relabel): - Badge → linked `Formal_Methods: Rocq + Kani (partial)` pointing at the Formal Verification section (informational, not a false CI-gate claim). - Tagline → narrowed to the core stages actually proven + a scope caveat. - Formal Verification section → rewritten to state the 350-proof coverage honestly (what's proved vs placeholder, forward-only simulation, the one Admitted lemma, Kani local-not-CI), linking proofs/STATUS.md. Not addressed here (infra): #337(b) gating the converging Kani harnesses in CI needs the Kani toolchain on the shared runners — a smithy-infra change. Refs #337. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
LS-N verification gate✅ 59/59 approved LS entries verified
Approved Failed LS entries(none) Missing regression tests(none) Updated automatically by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the README verification claim to match the actual evidence (the claim-verification "relabel-and-gate" pattern #337 asks for). Grounded in
proofs/STATUS.mdandmeld-core/src/abi_proofs.rs.Why the old claim overstated
Formally_Verifiedbadge — unlinked, reflects no job.Admitted.VERIFICATION SUCCESSFULlocally (SR-40), not gated in CI (shared runners lack the Kani toolchain); ABI size/align + aggregate-padding contracts fell back to unit tests.What changed (all README)
Formal_Methods: Rocq + Kani (partial)→#formal-verification(informational, not a false CI-gate).Admittedlemma called out; Kani local-not-CI; unit-test fallback noted. Linksproofs/STATUS.md.This neither over- nor under-sells — it credits the genuine 350-proof body of work while scoping it accurately.
Not addressed here
#337(b) — gating the converging Kani harnesses in CI — needs the Kani toolchain on the shared smithy runners (an infra change), so it's a follow-up, not this docs PR.
Refs #337.
🤖 Generated with Claude Code