docs(witness): correct scoped-gate host-invariance overclaim (#128) - #225
Merged
Conversation
The scoped count is far more stable than the whole-wasm total but NOT perfectly host-invariant: measured 5 on linux CI (varint 3 + mod.rs:455 2) vs 3 on macoOS local (mod.rs:455 is fully covered there). The prior comment claimed "stable across host", which a local macOS run disproves. Clarify that the baseline is calibrated on the CI host (linux, authoritative); lower counts elsewhere PASS (3 <= 5) so no local override is ever needed to go green; the SRC_BASELINE_GAP knob is for CI re-calibration, NOT for silencing a red locally — a host yielding MORE than baseline is a real finding. Make the improvement notice CI-host-aware so nobody lowers the committed baseline from a non-CI count. Gate assertion logic byte-unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012aR3Md1h46K9wAUWMQiESH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the v0.10.0 witness-gate scoping. A local macOS run showed the scoped count is 3 (not the linux-CI 5) — verify-core's own branches lay out differently per target. The gate is still correct (macOS 3 <= baseline 5 passes; no false red), but my comment claimed host-invariance it doesn't have. Corrects the comment + makes the improvement notice CI-host-aware so nobody lowers the committed baseline from a non-CI count. Gate assertion logic is byte-unchanged — comments + one notice string only.
🤖 Generated with Claude Code