docs(rivet): keep the DWARF verification artifact current with steps 1-4 (VCR-DBG-001, #242) - #416
Merged
Merged
Conversation
…1-4 (VCR-DBG-001, #242) SWVER-016 was written when only DWARF steps 1-2 (decoder op_offsets + .debug_line read) were implemented. Steps 3 (compose, #414) and 4-emit-logic (#415) have since landed with their own passing tests, leaving the verification artifact stale. Updates SWVER-016 to verify the full frozen-safe read→compose→emit LOGIC (steps 1-4) and reference all the tests that discharge it: wasm_decoder op_offsets, dwarf_line_read_spike, dwarf_coherent_fixture, dwarf_compose_step3 + dwarf_line:: unit tests, dwarf_emit_roundtrip_step4. The GATED step-4 ELF wiring (production gimli dep + ELF builder + host-link, v0.12.0) stays explicitly open. Keeps the requirement→test mapping accurate as the feature grew (the gap reported in pulseengine.eu#93) — no coverage-count change (VCR-DBG-001 already covered), just an honest, current trace. Frozen-safe: rivet artifact only, zero codegen, frozen fixtures bit-identical, rivet non-xref 0; all referenced tests verified passing. Trace: skip Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SWVER-016was written when only DWARF steps 1-2 were implemented. Steps 3 (compose, #414) and 4-emit-logic (#415) have since landed with passing tests, so the verification artifact was stale (referenced only the decoder+read).Updates SWVER-016 to verify the full frozen-safe read→compose→emit LOGIC and reference all the tests that discharge it:
wasm_decoderop_offsets,dwarf_line_read_spike,dwarf_coherent_fixture,dwarf_compose_step3+dwarf_line::units,dwarf_emit_roundtrip_step4. The gated step-4 ELF wiring (production gimli dep + ELF builder + host-link, v0.12.0) stays explicitly open.Why
Keeps the requirement→test mapping accurate as the feature grew — the gap reported in pulseengine.eu#93. No coverage-count change (VCR-DBG-001 was already covered); just an honest, current trace.
Frozen-safe
rivet artifact only; zero codegen; frozen fixtures bit-identical; rivet non-xref 0; all referenced tests verified passing.
Refs: #242, VCR-DBG-001, pulseengine.eu#93.
🤖 Generated with Claude Code