Skip to content

fix(dwarf): adapt LineProgram::new to gimli 0.33 6-arg signature (#436 fallout) #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avrabe merged 1 commit into from
Jun 22, 2026
Merged

fix(dwarf): adapt LineProgram::new to gimli 0.33 6-arg signature (#436 fallout) #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/synth-core/src/dwarf_line.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,14 @@ pub fn emit_debug_sections(table: &[(u64, u32)], text_sym: usize) -> Vec<Emitted
// high_pc one past the last mapped address.
let high_pc = table.iter().map(|&(a, _)| a).max().unwrap_or(0) + 1;

// gimli 0.33 split the comp-dir/file args: (working_dir, source_dir,
// source_file, source_file_info). source_dir = None ⇒ the file sits in
// working_dir, matching the previous single-dir behaviour.
let mut program = LineProgram::new(
encoding,
gimli::LineEncoding::default(),
LineString::String(b"/synth".to_vec()),
None,
LineString::String(b"synth.wasm".to_vec()),
None,
);
Expand Down
2 changes: 2 additions & 0 deletions crates/synth-core/tests/dwarf_emit_roundtrip_step4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,12 @@ fn emit_dwarf(table: &[(u64, u32)]) -> HashMap<String, Vec<u8>> {
address_size: 4,
};
let mut dwarf = DwarfUnit::new(encoding);
// gimli 0.33: (working_dir, source_dir, source_file, source_file_info).
let mut program = LineProgram::new(
encoding,
gimli::LineEncoding::default(),
LineString::String(b"/synth".to_vec()),
None,
LineString::String(b"dwarf_coherent.rs".to_vec()),
None,
);
Expand Down
Loading