Skip to content

Update Python versions #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
schuenke wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Update Python versions #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
723c3af
update python version in tests to ["3.7", "3.12", "3.13", "3.14"]
schuenke May 27, 2026
a9f929a
update Python badge in README
schuenke May 27, 2026
ea96321
reduce test matrix to min (3.8) and stable release (3.14) version
schuenke May 27, 2026
7385681
change default python version in report_pytest to 3.14
schuenke May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.8", "3.14"]

@conveyanand conveyanand May 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python-version defines Python 3.8 and 3.14 jobs, but the workflow did not use version for python setup.
The current implementation will run both jobs using the default Python from ubuntu-latest.
For example, if the current ubuntu-latest image version is 24.04, the default python version is Python 3.12.

include-sigpy: [true]

steps:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/report_pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ jobs:
actions: read # Required for downloading artifacts
pull-requests: write # Required for posting PR comments
steps:
# use the results of python 3.12, consider this as target platform
- name: Download PyTest report artifact for Python 3.12
# use the results of python 3.14, consider this as target platform
- name: Download PyTest report artifact for Python 3.14
uses: actions/download-artifact@v8
with:
name: pytest-report-3.12-true
name: pytest-report-3.14-true
run-id: ${{ github.event.workflow_run.id }}
github-token: ${{ secrets.GITHUB_TOKEN }}

Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
with:
run-id: ${{ github.event.workflow_run.id }}
github-token: ${{ secrets.GITHUB_TOKEN }}
name: pytest-report-3.12-true
name: pytest-report-3.14-true

- name: Post PyTest Coverage Comment on push
id: coverage_comment
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<p align = "left">

[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
[![Python](https://img.shields.io/badge/python-3.7--3.13-blue)](https://pypi.org/project/pypulseq/)
[![Python](https://img.shields.io/badge/python-3.8%2B-blue)](https://pypi.org/project/pypulseq/)
[![FAIR checklist badge](https://fairsoftwarechecklist.net/badge.svg)](https://fairsoftwarechecklist.net/v0.2?f=31&a=32113&i=32322&r=133)

</p>
Expand Down
Loading