Open
Conversation
Faraday 2 was released in early 2022. As part of this major release, authentication helper methods (such as basic_auth) were removed from the Connection object and into middleware. This commit updates vmfloaty's dependency on Faraday to ~> 2 and updates the Http class to use the new authentication middleware. This upgrade is helpful because, in a CI context, vmfloaty is often installed alongside other gems that use Faraday >= 2, and vmfloaty's current dependency on Faraday ~> 1.5, >= 1.5.1 can cause unexpected dependency resolution. You can read more about this unexpected dependency behavior in this GitHub issue: puppetlabs/orchestrator_client-ruby#41
Author
|
The Ruby 2.7 tests are failing because of dependency compatibility, but I'm not sure if Ruby 2.7 compatibility is still needed or desired since it's been end-of-life for a few years now. The next-oldest version of Ruby used in tests, 3.0, seems to work fine. |
Author
|
Closing/reopening to rekick label check |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faraday 2 was released in early 2022. As part of this major release, authentication helper methods (such as basic_auth) were removed from the Connection object and into middleware.
This commit updates vmfloaty's dependency on Faraday to ~> 2 and updates the Http class to use the new authentication middleware.
This upgrade is helpful because, in a CI context, vmfloaty is often installed alongside other gems that use Faraday >= 2, and vmfloaty's current dependency on Faraday ~> 1.5, >= 1.5.1 can cause unexpected dependency resolution.
You can read more about this unexpected dependency behavior in this GitHub issue: puppetlabs/orchestrator_client-ruby#41
Status
[Ready for Merge | In Progress | ???]
Description
FIXME
Related Issues
Todos