Skip to content

Fix submodule detection, the CleanupArtifacts NameError and the skippable Bandit scan #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Paebbels merged 1 commit into from
Aug 3, 2026
Merged

Fix submodule detection, the CleanupArtifacts NameError and the skippable Bandit scan #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/CheckCodeQuality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ jobs:

- name: 👮 Bandit
id: bandit
if: inputs.artifact != ''
run: |
set +e

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/CleanupArtifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
case [prefix, key, postfix] if key in artifactNames:
artifacts.append(f"{prefix}{artifactNames[key]}{postfix}")
case _:
printf(f"Name '{name}' not found in JSON dictionary.")
print(f"Name '{name}' not found in JSON dictionary.")

print("Artifact to delete:")
for name in artifacts:
Expand Down Expand Up @@ -143,7 +143,7 @@ jobs:
case [prefix, key, postfix] if key in artifactNames:
artifacts.append(f"{prefix}{artifactNames[key]}{postfix}")
case _:
printf(f"Name '{name}' not found in JSON dictionary.")
print(f"Name '{name}' not found in JSON dictionary.")

print("Artifact to delete:")
for name in artifacts:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/PrepareJob.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,9 +366,9 @@ jobs:
fi

# Submodules
if [[ -f .gitsubmodules ]]; then
git_modules_file=.gitmodules # $(git rev-parse --show-toplevel)/.gitmodules
if [[ -f "${git_modules_file}" ]]; then
has_submodules="true"
git_modules_file=.gitmodules # $(git rev-parse --show-toplevel)/.gitmodules
git_submodule_count="$(grep -Po '(?<=\[submodule \")(.*)(?=\"\])' "${git_modules_file}" | wc -l)"
git_submodule_names="$(grep -Po '(?<=\[submodule \")(.*)(?=\"\])' "${git_modules_file}" | paste -sd ':' -)"
git_submodule_paths="$(git config --file "${git_modules_file}" --null --name-only --get-regexp '\.path$' | xargs -0 -n1 git config --file "${git_modules_file}" --get | paste -sd ':' -)"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/_Checking_CleanupArtifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,10 @@ jobs:
- Package
with:
json: ${{ needs.Params.outputs.artifact_names }}
# Deliberate added 'unknown_key' for exception testing.
artifact-json-ids: >-
unittesting_xml:-*
unknown_key
Comment thread
Paebbels marked this conversation as resolved.
# The package artifact is kept on tagged runs, so 'PublishOnPyPI.yml' can still consume it.
json2: ${{ needs.Params.outputs.artifact_names }}
condition2: ${{ ! startsWith(github.ref, 'refs/tags') }}
Expand Down
Loading