Skip to content

Add plot of predictions#918

Merged
NicolaCourtier merged 35 commits intodevelopfrom
add-plot-predictive
Apr 20, 2026
Merged

Add plot of predictions#918
NicolaCourtier merged 35 commits intodevelopfrom
add-plot-predictive

Conversation

@NicolaCourtier
Copy link
Copy Markdown
Member

Description

Adding the predictive plot from @YannickNoelStephanKuhn's PR #854.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctest
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 85.98131% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.06%. Comparing base (4628a65) to head (4641acc).
⚠️ Report is 54 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/optimisers/ep_bolfi_optimiser.py 80.64% 6 Missing ⚠️
pybop/samplers/base_sampler.py 70.58% 5 Missing ⚠️
pybop/plot/predictive.py 90.62% 3 Missing ⚠️
pybop/costs/feature_distances.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #918      +/-   ##
===========================================
+ Coverage    89.41%   92.06%   +2.65%     
===========================================
  Files           63       74      +11     
  Lines         4857     5762     +905     
===========================================
+ Hits          4343     5305     +962     
+ Misses         514      457      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NicolaCourtier NicolaCourtier marked this pull request as ready for review April 10, 2026 11:01
@SarahRo
Copy link
Copy Markdown
Contributor

SarahRo commented Apr 16, 2026

Looks good. Thank you. Would it make sense to look at the test coverage before merging?

@NicolaCourtier NicolaCourtier merged commit b7fdbd4 into develop Apr 20, 2026
34 of 35 checks passed
@NicolaCourtier NicolaCourtier deleted the add-plot-predictive branch April 20, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants