Repository navigation
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Schema adaptation treats a missing physical column as an expected case, but
Schema::index_offormats an error listing every field before the adapter discards it. This adds work when reading files with evolving schemas.What changes are included in this PR?
Use the same name lookup through
Fields::find, which returnsNonewithout constructing the error. Add a focused benchmark for present and missing columns in 16- and 128-field schemas.Are these changes tested?
The 36 adapter unit tests, full-workspace Clippy with warnings denied, and the extended test suite pass. On an arm64 Mac, the missing-column benchmark improved from 558 to 266 ns (16 fields) and from 2.00 µs to 343 ns (128 fields). Present-column cases were also faster. These are isolated microbenchmarks, not an end-to-end query claim.
Are there any user-facing changes?
No. Missing nullable columns still become null; missing non-nullable columns still error. There is no public API change.