Repository navigation
Backport named_struct dialect-aware unparsing - #80
Open
friendlymatthew wants to merge 1 commit into
Open
friendlymatthew wants to merge 1 commit into
friendlymatthew wants to merge 1 commit into
Conversation
Member
|
Thanks. Let's first fix / get apache#25661 merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports apache#25661 onto the DataFusion commit currently used by Platform.
DataFusion emits
named_structas dictionary syntax for dialects that cannot parse it, breaking SQL round trips. This emitsnamed_struct(...)for those dialects while preserving dictionary syntax where supported.Supersedes #78 with a single upstream-linked backport commit. The only compatibility adaptation keeps the DF55 branch's
chunks_exact(2)iteration in place of current Apachemain'sas_chunks::<2>().Validation:
cargo test -p datafusion-sqlcargo clippy --all-targets --all-features -- -D warnings