feat: Make windows-compatible#66
Conversation
|
Good day, @samuelcolvin! |
|
Thanks for this, and sorry for the slow response! 🙏 I reproduced the bug on Windows (cp1252) and confirmed the fix works with no regressions. One suggestion before we merge: rather than adding a configurable Concretely that means: drop the Happy to push this tweak myself if that's easier. Thanks again! |
|
@hramezani, hey! Thank you very much for the response! I think this is a nice idea to simply hardcode it. Because since 3.15 we will have "utf-8" by default anyway |
|
@hramezani, should be good, please check |
Summary
Hey here!
Thank you very much for the library, it is really useful and helpful
This PR fixes how
pytest-examplesworks on Windows with sane (utf-8) defaultMotivation
I'm using
pytest-exampleslibrary in a small library I will release, and noticed that on Windows I get errors when try to run tests in docs with emojisWindows has a thing where if you don't specify encoding, the default regional encoding is used, which is never
utf-8Traceback in my project, where I use
pytest-exampleswith current code:Result of a test I have added in this PR with current code: