Fix POSIX sh (dash) compatibility in pyenv-virtualenv-init#526
Merged
Conversation
pyenvgh-525 Assisted by Qwen3-Coder-30B-A3B-Instruct via OpenCode.
native-api
requested changes
Apr 21, 2026
This reverts commit 57ac377.
native-api
approved these changes
Apr 21, 2026
Contributor
Author
|
Thanks @native-api! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #525.
v1.3.0 introduced bash-specific array syntax which breaks on systems where /bin/sh is dash. This fix replaces bash arrays with POSIX-compliant string concatenation, restoring sh compatibility while preserving the caching optimization. Test coverage has been added.
Assisted by Qwen3-Coder-30B-A3B-Instruct via OpenCode.