connectors: close stdin after writing any input #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out some applications will wait on stdin being closed before going anything (ollama), see: #1355
Fizzadar
force-pushed
the
close-stdin-after-writing
branch
from
6bd5f2f to
c576900
Compare
Member
Author
|
I believe this to be safe because this is what happens when you pipe things |
|
It seems like it'd be safe. I'm sure there's some random edge case that could be broken the other way around... but I can't think of one that I've ever done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out some applications will wait on stdin being closed before going anything (ollama), see: #1355